bpf: xdp: use CT tuple hash for tunnel encap's source port #26177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianwiedmann
added
sig/datapath
julianwiedmann
force-pushed
the
1.14-xdp-tunnel-source-port
branch
from
455d76e
to
bf6906a
Compare
|
/test |
julianwiedmann
force-pushed
the
1.14-xdp-tunnel-source-port
branch
from
bf6906a
to
8f13b1b
Compare
|
/test |
hash_from_tuple_v*() isn't perfect (as it ignores the .daddr), but much better than what we currently have. The one path where we might notice the reduced entropy is in a config with EgressGW and native-routing, when processing EgressGW reply traffic with non-service protocol (ICMP or other exotic types). As here we currently don't extract any L4 ports either. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
julianwiedmann
force-pushed
the
1.14-xdp-tunnel-source-port
branch
from
8f13b1b
to
5c967b3
Compare
|
Dropped the manual update of the CT tuple after RevDNAT. |
|
/test |
julianwiedmann
added
the
release-blocker/1.14
|
(marking as blocker so it doesn't fall through the cracks) |
julianwiedmann
added
the
kind/enhancement
maintainer-s-little-helper
bot
added
the
ready-to-merge
Does this need further discussion before we merge? cc @jibi |
jibi
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(follow-on to #24422)
hash_from_tuple_v*()isn't perfect (as it ignores the .daddr), but much better than what we currently have.The one path where we might notice the reduced entropy is in a config with EgressGW and native-routing, when processing EgressGW reply traffic with non-service protocol (ICMP or other exotic types). As here we currently don't extract any L4 ports either.