Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/workflows: don't error out if pkill finds no processes #26357

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

lmb
Copy link
Contributor

@lmb lmb commented Jun 19, 2023

The pkill invocation in GH workflows is meant to kill background tasks started earlier in the workflow. It seems like some of them exit of their own accord, with tests still passing.

Ignore the pkill error code 1 which indicates that no processes were matched / signalled:

   1      No processes matched or none of them could be signalled.

Fixes #26075

@lmb lmb added area/CI Continuous Integration testing issue or flake release-note/minor This PR changes functionality that users may find relevant to operating Cilium. ci/flake This is a known failure that occurs in the tree. Please investigate me! labels Jun 19, 2023
@lmb lmb requested a review from nbusseneau June 19, 2023 14:20
@lmb lmb requested review from a team as code owners June 19, 2023 14:20
@lmb lmb force-pushed the ignore-pkill-no-such-process branch from 56f68fb to 067f3b8 Compare June 26, 2023 09:41
@lmb
Copy link
Contributor Author

lmb commented Jun 26, 2023

/test

@lmb
Copy link
Contributor Author

lmb commented Jun 26, 2023

Hit #25972

@lmb lmb force-pushed the ignore-pkill-no-such-process branch from 067f3b8 to 87f61f3 Compare July 3, 2023 13:04
@lmb
Copy link
Contributor Author

lmb commented Jul 3, 2023

/test

@lmb
Copy link
Contributor Author

lmb commented Jul 3, 2023

/test-ci-ginkgo

The pkill invocation in GH workflows is meant to kill background
tasks started earlier in the workflow. It seems like some of them
exit of their own accord, with tests still passing.

Ignore the pkill error code 1 which indicates that no processes
were matched / signalled:

       1      No processes matched or none of them could be signalled.

Fixes cilium#26075

Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
@lmb lmb force-pushed the ignore-pkill-no-such-process branch from 87f61f3 to 7d4599d Compare July 4, 2023 08:38
@lmb
Copy link
Contributor Author

lmb commented Jul 4, 2023

/test

@lmb lmb added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 4, 2023
@borkmann borkmann merged commit f6600fd into cilium:main Jul 5, 2023
65 checks passed
@joestringer
Copy link
Member

Heads up that release-note/minor is reserved for user-facing changes. Typically CI changes would use release-note/ci.

@joestringer joestringer added release-note/ci This PR makes changes to the CI. and removed release-note/minor This PR changes functionality that users may find relevant to operating Cilium. labels Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake ci/flake This is a known failure that occurs in the tree. Please investigate me! ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: ConformanceAKS - Clean up Cilium
4 participants