-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.github/workflows: don't error out if pkill finds no processes #26357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmb
added
area/CI
Continuous Integration testing issue or flake
release-note/minor
This PR changes functionality that users may find relevant to operating Cilium.
ci/flake
This is a known failure that occurs in the tree. Please investigate me!
labels
Jun 19, 2023
nbusseneau
approved these changes
Jun 22, 2023
lmb
force-pushed
the
ignore-pkill-no-such-process
branch
from
June 26, 2023 09:41
56f68fb
to
067f3b8
Compare
/test |
Hit #25972 |
lmb
force-pushed
the
ignore-pkill-no-such-process
branch
from
July 3, 2023 13:04
067f3b8
to
87f61f3
Compare
/test |
/test-ci-ginkgo |
The pkill invocation in GH workflows is meant to kill background tasks started earlier in the workflow. It seems like some of them exit of their own accord, with tests still passing. Ignore the pkill error code 1 which indicates that no processes were matched / signalled: 1 No processes matched or none of them could be signalled. Fixes cilium#26075 Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
lmb
force-pushed
the
ignore-pkill-no-such-process
branch
from
July 4, 2023 08:38
87f61f3
to
7d4599d
Compare
/test |
lmb
added
the
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
label
Jul 4, 2023
Heads up that |
joestringer
added
release-note/ci
This PR makes changes to the CI.
and removed
release-note/minor
This PR changes functionality that users may find relevant to operating Cilium.
labels
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/CI
Continuous Integration testing issue or flake
ci/flake
This is a known failure that occurs in the tree. Please investigate me!
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/ci
This PR makes changes to the CI.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pkill invocation in GH workflows is meant to kill background tasks started earlier in the workflow. It seems like some of them exit of their own accord, with tests still passing.
Ignore the pkill error code 1 which indicates that no processes were matched / signalled:
Fixes #26075