Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.13: ci: use Ariane to trigger workflows #26580

Merged
merged 2 commits into from
Jul 5, 2023
Merged

Conversation

nbusseneau
Copy link
Member

Please see the main PR at #26237 for full context and discussions.

@nbusseneau nbusseneau added area/CI-improvement Topic or proposal to improve the Continuous Integration workflow release-note/ci This PR makes changes to the CI. backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. labels Jun 30, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added the kind/backports This PR provides functionality previously merged into master. label Jun 30, 2023
@nbusseneau nbusseneau force-pushed the pr/gh-app-trigger-rework-1.13 branch 5 times, most recently from 20d4534 to 9a2e1fd Compare July 3, 2023 13:11
@nbusseneau
Copy link
Member Author

/ariane-test-backport-1.13

@nbusseneau
Copy link
Member Author

image
Removing temporary test commit.

@nbusseneau nbusseneau force-pushed the pr/gh-app-trigger-rework-1.13 branch from 9a2e1fd to 8f60f4f Compare July 3, 2023 14:16
@nbusseneau nbusseneau marked this pull request as ready for review July 3, 2023 14:16
@nbusseneau nbusseneau requested review from a team as code owners July 3, 2023 14:16
@@ -0,0 +1,15 @@
# List of test cases for conformance-gke with helm installation options
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy paste? )

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@viktor-kurchenko That's just how the file is in main, it was probably a copy-paste issue there. If you want to fix it, let's fix in main :p

@nbusseneau nbusseneau force-pushed the pr/gh-app-trigger-rework-1.13 branch from 8f60f4f to b42b1ce Compare July 5, 2023 12:05
[ upstream commit 4a9ee81 ]

This is a custom backport, please see upstream commit for full details.

Ariane is a new GitHub App intended to trigger Cilium CI workflows based
on trigger phrases commented in pull requests, in order to replace the
existing `issue_comment`-based workflows and simplify our CI stack.

This commit adds a configuration setting up triggers such that existing
1.13 workflows can be triggered with the usual `/test-backport-1.13`,
and based on the same PR changelist match / ignore rules.

Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
[ upstream commit 9949c5a ]

This is a custom backport, please see upstream commit for full details.

In this commit, we move stable workflows from the `main` branch back
into the 1.13 stable branch now that workflows are triggered via
`workflow_dispatch` events in the appropriate context.

Since these new workflows were previously living in `main`, we also need
to backport dependencies on `.github/actions` configuration files. We
take the opportunity to adjust the configuration files as appropriate,
notably in terms of K8s version coverage, to ensure that we only test
K8s versions officially supported by the stable branch.

Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
@nbusseneau nbusseneau force-pushed the pr/gh-app-trigger-rework-1.13 branch from b42b1ce to b1ad7b3 Compare July 5, 2023 12:07
@aanm aanm merged commit 88f4eb1 into v1.13 Jul 5, 2023
36 of 37 checks passed
@aanm aanm deleted the pr/gh-app-trigger-rework-1.13 branch July 5, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI-improvement Topic or proposal to improve the Continuous Integration workflow backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants