Default spire.install.enabled to true #26864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meyskens
added
the
release-note/minor
This will default install Spire with Cilium if Spire auth is enabled. It will remove the need to set two flags when enabling Spire based Mutual Auth with Cilium Managed Spire. Signed-off-by: Maartje Eyskens <maartje.eyskens@isovalent.com>
This will remove the spire enabled flag from the e2e test config as it is now the default option. Signed-off-by: Maartje Eyskens <maartje.eyskens@isovalent.com>
meyskens
force-pushed
the
meyskens/spire-default-install
branch
from
f342b62
to
839f2ee
Compare
|
/test |
kaworu
approved these changes
Jul 18, 2023
nbusseneau
approved these changes
Jul 18, 2023
youngnick
approved these changes
Jul 19, 2023
meyskens
added
the
needs-backport/1.14
meyskens
added
the
ready-to-merge
21 tasks
nbusseneau
added
backport-pending/1.14
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.14
in 1.14.0
nbusseneau
added
backport-done/1.14
maintainer-s-little-helper
bot
moved this from Backport pending to v1.14
to Backport done to v1.14
in 1.14.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change sets
authentication.mutual.spire.install.enabledto true. It will only take affect whenauthentication.mutual.spire.enabledis also true. This eliminates the need for 2 flags when installed with built-in spire which is the most common use.Fixes: #26771