ipam: deepcopy interface resource correctly. #26998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
tommyp1ckles
force-pushed
the
pr/tp/fix-false-deepcopy-causing-races
branch
2 times, most recently
from
0b52cfe
to
0ebd5f1
Compare
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
tommyp1ckles
force-pushed
the
pr/tp/fix-false-deepcopy-causing-races
branch
from
0ebd5f1
to
39e1697
Compare
christarazi
approved these changes
Aug 1, 2023
gandro
approved these changes
Aug 2, 2023
christarazi
force-pushed
the
pr/tp/fix-false-deepcopy-causing-races
branch
from
39e1697
to
5976a48
Compare
|
/test |
tommyp1ckles
force-pushed
the
pr/tp/fix-false-deepcopy-causing-races
branch
from
5976a48
to
4b4e8d0
Compare
|
/test |
|
failures are flake this is partially trying to address |
|
/test |
1 similar comment
|
/test |
tommyp1ckles
force-pushed
the
pr/tp/fix-false-deepcopy-causing-races
branch
from
4b4e8d0
to
5383cea
Compare
tommyp1ckles
force-pushed
the
pr/tp/fix-false-deepcopy-causing-races
branch
from
5383cea
to
c4b8d3e
Compare
|
/test |
|
Think this is still desired, if tests pass following the last fix for the referenced test. |
tommyp1ckles
force-pushed
the
pr/tp/fix-false-deepcopy-causing-races
branch
from
c4b8d3e
to
d2c24d0
Compare
|
@hemanthmalla Could you take a look on behalf of cilium/azure? |
maintainer-s-little-helper
bot
added
the
ready-to-merge
tommyp1ckles
added
needs-backport/1.13
gandro
added
backport-pending/1.15
gandro
added
backport-pending/1.14
gandro
added
backport-pending/1.13
github-actions
bot
added
backport-done/1.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ipam: deepcopy interface resource correctly.
Currently only used by azure ipam test mocks, was resulting in race
condition prone code where underlying interface addresses where being
shared across resources.
This ensures that the revision interface is correctly deepcopied such
that the underlying resource is also safely copied.
This seems at least partially related to flake #26617.
Addresses: #26617
Signed-off-by: Tom Hadlaw tom.hadlaw@isovalent.com