New header "X-Load-Balancing-Endpoint-Weight" returned by service health #27017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit df8f288a3fcda1cbaab9167ca851360301e4dd2a does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
maintainer-s-little-helper
bot
added
dont-merge/needs-sign-off
github-actions
bot
added
the
kind/community-contribution
returned from service health. Value of the header is number of local endpoints. Signed-off-by: Cezary Zawadka <czawadka@google.com>
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-sign-off
alan-kut
approved these changes
Jul 25, 2023
|
/label release-note/misc |
joestringer
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
ysksuzuki
approved these changes
Jul 26, 2023
|
@ysksuzuki @joestringer @alan-kut Who should be able to merge this branch? |
|
/test |
|
All tests must pass and all codeowner reviews must be checked off, then typically there's a rotating hat for a committer to sweep through and merge PRs like this. I've kicked off the full testsuite to confirm the other requirement before merge. |
|
Going to give the tests one more crack, I've seen some weird connectivity shenanigans in the last 24 hours. |
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add new header "X-Load-Balancing-Endpoint-Weight" returned from service health. Value of the header is number of local endpoints. Header can be used in weighted load balancing. Parsing header for number of endpoints is faster than unmarshalling json from the content body, and it can be returned via HTTP HEAD method.
The header has been already added to kube-proxy service health code in kubernetes/kubernetes#118999 (will be released in kubernetes v1.28)