Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hubble-ui): Add probes for Hubble-ui #27028

Merged
merged 1 commit into from
Aug 2, 2023
Merged

feat(hubble-ui): Add probes for Hubble-ui #27028

merged 1 commit into from
Aug 2, 2023

Conversation

mkilchhofer
Copy link
Contributor

@mkilchhofer mkilchhofer commented Jul 24, 2023 •
edited

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • [na ] If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

As this is a common pattern for all Kubernetes pods, I think it doesn't require additional use cases.
But: I contributed the /healthz endpoint only a few days ago. The feature for the backend requires hubble-ui >=0.12:

Resolves: cilium/hubble-ui#586

Hubble-ui now supports liveness and readiness probes

/cc: @geakstr

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 24, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Jul 24, 2023
@mkilchhofer mkilchhofer force-pushed the feature/add_probes_for_hubble-ui branch from 9e27872 to 6088472 Compare July 24, 2023 14:39
@mkilchhofer mkilchhofer marked this pull request as ready for review July 24, 2023 14:44
@mkilchhofer mkilchhofer requested review from a team as code owners July 24, 2023 14:44
@mkilchhofer mkilchhofer force-pushed the feature/add_probes_for_hubble-ui branch from 6088472 to f760510 Compare July 24, 2023 21:07
gandro
gandro reviewed Jul 25, 2023
View reviewed changes
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Please note that you will have to update the values.yaml.tmpl file instead of the values.yaml file and run make -C install/kubernetes and make -C Documentation to update all generated files relating to Helm.

@gandro gandro added sig/hubble Impacts hubble server or relay area/helm Impacts helm charts and user deployment experience release-note/misc This PR makes changes that have no direct user impact. labels Jul 25, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 25, 2023
@mkilchhofer mkilchhofer force-pushed the feature/add_probes_for_hubble-ui branch from f760510 to 6717de5 Compare July 25, 2023 09:12
gandro
gandro approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@gandro gandro left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Helm-wise looks good to me! Thanks! Let's also get a review from a Hubble UI code owner

@gandro gandro requested a review from geakstr July 25, 2023 09:38
@gandro
Copy link
Member

gandro commented Jul 25, 2023

/test

@geakstr
Copy link
Contributor

geakstr commented Jul 26, 2023

LGTM!

@youngnick
Copy link
Contributor

Hi @mkilchhofer, sorry, but with #27002 merging, there's been a change to the required jobs to pass CI, so I recommend rebasing and then one of us can re-trigger the testing.

@mkilchhofer
feat(hubble-ui): Add probes for Hubble-ui
ed6ef52 
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
@mkilchhofer mkilchhofer force-pushed the feature/add_probes_for_hubble-ui branch from 6717de5 to ed6ef52 Compare July 28, 2023 12:18
@mkilchhofer
Copy link
Contributor Author

@youngnick @gandro rebased as requested :-)

@youngnick
Copy link
Contributor

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Aug 2, 2023
@gandro gandro merged commit bfd3629 into cilium:main Aug 2, 2023
59 checks passed
@mkilchhofer mkilchhofer deleted the feature/add_probes_for_hubble-ui branch November 15, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@geakstr geakstr geakstr approved these changes

@youngnick youngnick youngnick approved these changes

Assignees
No one assigned
Labels
area/helm Impacts helm charts and user deployment experience kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/hubble Impacts hubble server or relay
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Health endpoints on both frontend/nginx and backend
4 participants
@mkilchhofer @gandro @geakstr @youngnick