[v1.13] Rename bpfClockProbe Helm variable #27034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ upstream commit e2d5ae9 ] Rename the Helm variable in values.yaml.tmpl as it was incorrectly named bpf.clockProbe instead of bpfClockProbe. This will cause the bpf clock probe to be disabled everywhere. Which is currently necessary as it can otherwise cause interrupted connections after an upgrade, due to the garbage collector removing valid entries. Signed-off-by: Margarita Manterola <marga@isovalent.com>
maintainer-s-little-helper
bot
added
backport/1.13
|
/test-backport-1.13 Job 'Cilium-PR-K8s-1.24-kernel-4.19' failed: Click to show.Test NameFailure OutputJenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.24-kernel-4.19/93/ If it is a flake and a GitHub issue doesn't already exist to track it, comment Then please upload the Jenkins artifacts to that issue. |
joestringer
added
the
release-blocker/1.13
|
/test-1.24-4.19 |
nathanjsweet
approved these changes
Jul 25, 2023
youngnick
approved these changes
Jul 26, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Author backport of #26981
[ upstream commit e2d5ae9 ]
Rename the Helm variable in values.yaml.tmpl as it was incorrectly named bpf.clockProbe instead of bpfClockProbe.
This will cause the bpf clock probe to be disabled everywhere. Which is currently necessary as it can otherwise cause interrupted connections after an upgrade, due to the garbage collector removing valid entries.