-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend API/CLI to support updating policy by label #27103
Extend API/CLI to support updating policy by label #27103
Conversation
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This is good. Just some nits. Otherwise, LGTM.
Commits 05af03cfb2801a406b08c82f9851093f45530ff9, 3d7f700b6e9116735d5025ebc0d947a141108420 do not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
Commits 05af03cfb2801a406b08c82f9851093f45530ff9, 3d7f700b6e9116735d5025ebc0d947a141108420 do not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
4f61a6c
to
d35f653
Compare
Commit 05af03cfb2801a406b08c82f9851093f45530ff9 does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
This change extends the HTTP API to allow updating the agent policy repository by label. This is existing functionality that this change just exposes over the HTTP API as well. The `cilium policy import` command has been updated to make this functionality available from the CLI. Signed-off-by: Dan Everton <deverton@godaddy.com>
d35f653
to
1e3c706
Compare
/test |
This change extends the HTTP API to allow updating the agent policy repository by label. This is existing functionality that this change just exposes over the HTTP API as well.
The
cilium policy import
command has been updated to make this functionality available from the CLI.