Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend API/CLI to support updating policy by label #27103

Merged

Conversation

deverton-godaddy
Copy link
Contributor

This change extends the HTTP API to allow updating the agent policy repository by label. This is existing functionality that this change just exposes over the HTTP API as well.

The cilium policy import command has been updated to make this functionality available from the CLI.

cli: Update `cilium policy import` to allow policy replacement by label

@deverton-godaddy deverton-godaddy requested review from a team as code owners July 26, 2023 23:03
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 26, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Jul 26, 2023
@dylandreimerink dylandreimerink added the release-note/misc This PR makes changes that have no direct user impact. label Aug 4, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 4, 2023
@dylandreimerink
Copy link
Member

/test

Copy link
Member

@nathanjsweet nathanjsweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is good. Just some nits. Otherwise, LGTM.

api/v1/openapi.yaml Outdated Show resolved Hide resolved
api/v1/openapi.yaml Outdated Show resolved Hide resolved
@maintainer-s-little-helper
Copy link

Commits 05af03cfb2801a406b08c82f9851093f45530ff9, 3d7f700b6e9116735d5025ebc0d947a141108420 do not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Aug 13, 2023
@maintainer-s-little-helper
Copy link

Commits 05af03cfb2801a406b08c82f9851093f45530ff9, 3d7f700b6e9116735d5025ebc0d947a141108420 do not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper
Copy link

Commit 05af03cfb2801a406b08c82f9851093f45530ff9 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

This change extends the HTTP API to allow updating the agent policy
repository by label. This is existing functionality that this change
just exposes over the HTTP API as well.

The `cilium policy import` command has been updated to make this
functionality available from the CLI.

Signed-off-by: Dan Everton <deverton@godaddy.com>
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Aug 13, 2023
@ti-mo
Copy link
Contributor

ti-mo commented Aug 16, 2023

/test

@joestringer joestringer merged commit 615f5d5 into cilium:main Aug 24, 2023
59 checks passed
@joestringer joestringer added release-note/minor This PR changes functionality that users may find relevant to operating Cilium. and removed release-note/misc This PR makes changes that have no direct user impact. labels Aug 24, 2023
@deverton-godaddy deverton-godaddy deleted the deverton/policy-put-options branch August 24, 2023 21:43
deverton-godaddy added a commit to deverton-godaddy/netreap that referenced this pull request Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/community-contribution This was a contribution made by a community member. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants