Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Improve wording for labels and services policies #27171

Merged
merged 2 commits into from
Aug 30, 2023
Merged

docs: Improve wording for labels and services policies #27171

merged 2 commits into from
Aug 30, 2023

Commits on Aug 29, 2023

  1. docs: Rename Labels-based endpoint policies 

    A user pointed out that what we call "Labels-based" policies are
actually matching the labels on Endpoints, but also explicitly *not*
matching labels on Services. To make this more clear, change the name
in the docs to Endpoints based policies.

Co-authored-by: Nathan Sweet <nathanjsweet@users.noreply.github.com>
Signed-off-by: Joe Stringer <joe@cilium.io>
    @joestringer @nathanjsweet
    joestringer and nathanjsweet committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    605d7f8 View commit details
    Browse the repository at this point in the history

  2. docs: Move services note about applicability higher 

    A user pointed out that the position of this callout made it seem like
the callout only applies to the first example rather than applying to
all Services based policies. Move the callout to the top of the section
to make the relationship clearer.

Signed-off-by: Joe Stringer <joe@cilium.io>
    @joestringer
    joestringer committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    6633dda View commit details
    Browse the repository at this point in the history