bpf: gate egressgw datapath on separate defines #27189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmb
added
release-note/minor
lmb
force-pushed
the
egw-datapath-split-defines
branch
from
429ff49
to
25b714e
Compare
|
/test |
|
Needs a rebase on top of #26952 since that already moves the code to a separate file. |
lmb
force-pushed
the
egw-datapath-split-defines
branch
from
25b714e
to
f5428dd
Compare
|
/test |
lmb
force-pushed
the
egw-datapath-split-defines
branch
from
f5428dd
to
12342bc
Compare
|
/test |
Add a new define ENABLE_EGRESS_GATEWAY_COMMON which enables the common egress gateway code. The existing ENABLE_EGRESS_GATEWAY flag now controls whether to check for egress gateway policies with static gateway IPs. This makes it easier to extend the codebase to with alternative implementations. Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
lmb
force-pushed
the
egw-datapath-split-defines
branch
from
12342bc
to
f957feb
Compare
|
/test |
1 similar comment
|
/test |
Move the CT reply check into egress_gw_request_needs_redirect so that alternative implementations can have their own CT state handling. Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
lmb
force-pushed
the
egw-datapath-split-defines
branch
from
b3db2e3
to
b32476d
Compare
jibi
approved these changes
Aug 2, 2023
| @@ -1065,7 +1065,7 @@ static __always_inline int handle_ipv4_from_lxc(struct __ctx_buff *ctx, __u32 *d | |||
| } | |||
| } | |||
|
|
|||
| #ifdef ENABLE_EGRESS_GATEWAY | |||
| #ifdef ENABLE_EGRESS_GATEWAY_COMMON | |||
There was a problem hiding this comment.
nit: let's just switch all of them to #if defined()?
| #define ENABLE_EGRESS_GATEWAY_COMMON | ||
| #endif | ||
|
|
||
| #ifdef ENABLE_EGRESS_GATEWAY_COMMON |
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bpf: gate egressgw datapath on separate defines
bpf: move CT checks into egress_gw_request_needs_redirect