Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

egressgw: tidy up Config handling #27221

Merged
merged 2 commits into from
Aug 4, 2023
Merged

egressgw: tidy up Config handling #27221

merged 2 commits into from
Aug 4, 2023

Conversation

lmb
Copy link
Contributor

@lmb lmb commented Aug 2, 2023

egressgw: move Config sanity checks into the manager

Move all the scattered config validation into the egress gateway manager. 
This serves as self documentation and makes it less likely that the warnings
will get out of date.

Signed-off-by: Lorenz Bauer <lmb@isovalent.com>

egressgw: gate common checks using method on Config

Call a method on Config instead of gating common checks required for egress
gateway on EnableIPv4EgressGateway. This allows introducing additional
implementations without changing code everywhere.

Signed-off-by: Lorenz Bauer <lmb@isovalent.com>

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 2, 2023
@lmb lmb added release-note/minor This PR changes functionality that users may find relevant to operating Cilium. feature/egress-gateway Impacts the egress IP gateway feature. area/modularization and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Aug 2, 2023
@lmb
Copy link
Contributor Author

lmb commented Aug 2, 2023

/test

lmb added 2 commits August 3, 2023 09:43
@lmb
egressgw: move Config sanity checks into the manager
987b690 
Move all the scattered config validation into the egress gateway manager.
This serves as self documentation and makes it less likely that the
warnings will get out of date.

Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
@lmb
egressgw: gate common checks using method on Config
1925f7a 
Call a method on Config instead of gating common checks required
for egress gateway on EnableIPv4EgressGateway. This allows
introducing additional implementations without changing code
everywhere.

Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
@lmb
Copy link
Contributor Author

lmb commented Aug 3, 2023

/test

@lmb
Copy link
Contributor Author

lmb commented Aug 3, 2023

ci-ipsec-e2e is a flake #26591

@lmb lmb marked this pull request as ready for review August 3, 2023 10:13
@lmb lmb requested review from a team as code owners August 3, 2023 10:13
jibi
jibi approved these changes Aug 4, 2023
View reviewed changes
Copy link
Member

@jibi jibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 👌

@jibi jibi merged commit 2daf870 into cilium:main Aug 4, 2023
58 of 59 checks passed
@lmb lmb deleted the egw-config-split branch August 7, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jibi jibi jibi approved these changes

@jschwinger233 jschwinger233 jschwinger233 approved these changes

@rgo3 rgo3 rgo3 approved these changes

@thorn3r thorn3r Awaiting requested review from thorn3r thorn3r is a code owner automatically assigned from cilium/sig-agent

@asauber asauber Awaiting requested review from asauber asauber is a code owner automatically assigned from cilium/cli

Assignees
No one assigned
Labels
area/modularization feature/egress-gateway Impacts the egress IP gateway feature. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lmb @jibi @jschwinger233 @rgo3