Commits on Aug 3, 2023

1. docs: Have Makefile print generated image tags when running with V=0 …

   When building Docker images for documentation with V=0, the Makefile for
   documentation does not print the name of the generated images.
   
   One particular example of calling the Makefile with V=0 is for Cilium's
   runtime tests in CI, with .travis/build.sh calling:
   
       V=0 make -j 2 --quiet
   
   This calls the default target for Cilium's main Makefile, which relies
   (among others) on the "postcheck" target, which in turns calls the
   "check" target from Documentation/Makefile, passing the V=0 flag. The
   absence of the "docs-builder" string from the logs make it harder to
   figure out whether the workflow successfully built the image.
   
   This commit simply adds the image tag (passed to Docker with "--tag",
   but not actually containing the version tag) to the invocation of
   $(ECHO_DOCKER), so that Documentation/Makefile can print it when we
   request a non-verbose build with V=0.
   
   Signed-off-by: Quentin Monnet <quentin@isovalent.com>

   

   qmonnet committed Aug 3, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 803221a
   • Browse repository at this point

   Copy the full SHA

   803221a View commit details

   Browse the repository at this point in the history