Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update renovate configuration for ginkgo and kindest/node #27347

Merged
merged 4 commits into from
Aug 8, 2023

Conversation

aanm
Copy link
Member

@aanm aanm commented Aug 8, 2023

read per commit

Signed-off-by: André Martins <andre@cilium.io>
Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm added the release-note/misc This PR makes changes that have no direct user impact. label Aug 8, 2023
@maintainer-s-little-helper
Copy link

Commit d57d150c38c3669b5f2499a0af9a4b5a73027984 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Aug 8, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Aug 8, 2023
@aanm aanm marked this pull request as ready for review August 8, 2023 12:46
@aanm aanm requested review from a team as code owners August 8, 2023 12:46
Signed-off-by: André Martins <andre@cilium.io>
Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm merged commit 2a5f632 into cilium:main Aug 8, 2023
44 checks passed
@aanm aanm deleted the pr/add-renovate-ginkgo branch August 9, 2023 08:38
Comment on lines +378 to +379
"groupName": "all kind-images main",
"groupSlug": "all-kind-images-main",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aanm these names seem to imply they only apply to the main branch, but this definitely seems to be applying to all branches. For example:

#27772

Is that what main is supposed to mean here? Should this section have a stanza to restrict the matchBaseBranches to main?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joestringer No, I think the "main" was a bad copy paste.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants