k8s: fix incorrect EndpointSlice API version [1.12] #27378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug that k8s watcher incorrectly chooses the discovery/v1beta1 EndpointSlice in environments where discovery/v1 EndpointSlice is available. The agent doesn't wait for the discovery/v1 EndpointSlice to be received and ends up removing live services because of this bug. The issue happens in the following scenario: 1. The agent initializes and runs the informers for Service and EndpointSlice. 2. The reflectors list the resources from kube-apiserver and replace DeltaFIFO. 3. The informers pop items from the DeltaFIFO and call the onAdd handler one by one. 4. If the Service handler is called first, ServiceCache.UpdateService doesn't emit the UpdateService event, because the service is not ready. (No backend) 5. The EndpointSlice handler is called next, ServiceCache.updateEndpoints emits UpdateService event. 6. The agent doesn't wait until the event triggered at step 5 is processed, and calls SyncWithK8sFinished. 7. The agent removes live services because it hasn't heard about it. (It is supposed to hear about those services in the event process triggered at step 5) fixes: cilium#27215 Signed-off-by: Yusuke Suzuki <yusuke-suzuki@cybozu.co.jp> Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
nebril
added
kind/backports
nebril
added
the
release-blocker/1.12
|
/test-backport-1.12 |
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #27277 to 1.12 branch.
This commit fixes a bug that k8s watcher incorrectly chooses the discovery/v1beta1 EndpointSlice in environments where discovery/v1 EndpointSlice is available.
The agent doesn't wait for the discovery/v1 EndpointSlice to be received and ends up removing live services because of this bug.
The issue happens in the following scenario:
fixes: #27215