Update kvstore_duration_operation_seconds to not include rate-limiting latency #27396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
marseel
changed the title
lambdanis
requested changes
Aug 9, 2023
Before, kvstore_duration_operation_seconds metric included time spent in rate-limiting. Now it does not include rate-limited time spent. This change makes metric more useful when troubleshooting if propagation delayes are caused by slow kvstore or rate-limiting. Users can still observe delayes caused by rate-limiting using metric api_limiter_wait_duration_seconds. Now, kvstore_duration_operation_seconds metric does not include errors caused by rate-limiting. Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
marseel
force-pushed
the
update_kvstore_metrics
branch
from
a255b61
to
0ae636e
Compare
marseel
added
the
release-note/minor
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
lambdanis
approved these changes
Aug 10, 2023
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before,
kvstore_duration_operation_secondsmetric included time spent in rate-limiting.Now it does not include rate-limited time spent.
This change makes the metric more useful when troubleshooting if propagation delays are caused by slow kvstore or rate-limiting.
Users can still observe delays caused by rate-limiting using metric
api_limiter_wait_duration_seconds