egressgw: inject datapath config via hive #27414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmb
added
release-note/minor
|
/test |
|
/test |
lmb
force-pushed
the
egw-node-config
branch
2 times, most recently
from
ec1323c
to
19b1ec4
Compare
|
/test |
|
/test |
|
/test |
The existing functionality to inject defines via a function is necessary for cases where the defines are not know at construction time. If they are known, it's nicer to be able to specify a plain map. This gives quicker feedback if duplicate defines are attempted. It also allows leaving the map nil if a feature is disabled, where in the existing implementation you'd need a dummy function. Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
Due to the ordering of header includes we sometimes miss defining HAVE_ENCAP even though the egress gateway code is enabled. Move the definition of ENABLE_EGRESS_GATEWAY_COMMON into common.h. Fixes: 6cad3dc ("bpf: gate egressgw datapath on separate defines") Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
Remove the hardcoded defines from the HeaderfileWriter and inject them via a hive value group instead. This allows adding back EGRESS_POLICY_MAP_SIZE. Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
|
/test |
dylandreimerink
approved these changes
Aug 14, 2023
maintainer-s-little-helper
bot
added
ready-to-merge
julianwiedmann
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
datapath: allow injecting defines into NodeConfig via a map
egressgw: inject datapath config via hive