Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpf: allow overriding Makefile variables #27492

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Conversation

lmb
Copy link
Contributor

@lmb lmb commented Aug 14, 2023

Consolidate the important variables at the top of bpf/Makefile and allow injecting custom logic via Makefile.override. This is the same approach used for the root Makefile as well.

Consolidate the important variables at the top of bpf/Makefile and
allow injecting custom logic via Makefile.override. This is the same
approach used for the root Makefile as well.

Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
@lmb lmb added release-note/minor This PR changes functionality that users may find relevant to operating Cilium. area/modularization labels Aug 14, 2023
@lmb
Copy link
Contributor Author

lmb commented Aug 14, 2023

/test

@lmb lmb marked this pull request as ready for review August 14, 2023 15:19
@lmb lmb requested a review from a team as a code owner August 14, 2023 15:19
Copy link
Member

@dylandreimerink dylandreimerink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Aug 15, 2023
@lmb lmb merged commit 7f54bb3 into cilium:main Aug 15, 2023
60 checks passed
@lmb lmb deleted the bpf-makefile-override branch August 15, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/modularization ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants