Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable prometheus metrics for cilium-operator and clustermesh's Etcd by default #27653

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Enable prometheus metrics for cilium-operator and clustermesh's Etcd by default #27653

merged 1 commit into from
Sep 29, 2023

Conversation

marseel
Copy link
Contributor

@marseel marseel commented Aug 23, 2023

Enable prometheus metrics for cilium-operator and clustermesh's Etcd by default.

Related: cilium/cilium-cli#1927

Cilium-operator and clustermesh's kvstore metrics are now enabled by default in Helm.

@marseel marseel requested review from a team as code owners August 23, 2023 11:46
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 23, 2023
@marseel marseel force-pushed the enable_prometheus_metrics_for_operator_and_clustermesh_etcd branch from dc1790a to 1d8bb2d Compare August 23, 2023 11:47
kaworu
kaworu requested changes Aug 23, 2023
View reviewed changes
install/kubernetes/cilium/values.yaml Outdated Show resolved Hide resolved
zacharysarah
zacharysarah approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@zacharysarah zacharysarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tommyp1ckles
tommyp1ckles approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@tommyp1ckles tommyp1ckles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, having these on by default makes a lot of sense

@marseel marseel force-pushed the enable_prometheus_metrics_for_operator_and_clustermesh_etcd branch from 1d8bb2d to 3b06435 Compare August 24, 2023 10:02
@marseel marseel added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Aug 24, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 24, 2023
@marseel marseel force-pushed the enable_prometheus_metrics_for_operator_and_clustermesh_etcd branch from 3b06435 to 730cc49 Compare August 28, 2023 14:18
@github-actions
Copy link

This pull request has been automatically marked as stale because it
has not had recent activity. It will be closed if no further activity
occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Sep 28, 2023
@marseel marseel removed the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Sep 28, 2023
@marseel marseel force-pushed the enable_prometheus_metrics_for_operator_and_clustermesh_etcd branch from 730cc49 to d7fae03 Compare September 28, 2023 08:48
@marseel
Enable operator and clustermesh Etcd metrics by default
7639283 
Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
@marseel marseel force-pushed the enable_prometheus_metrics_for_operator_and_clustermesh_etcd branch from d7fae03 to 7639283 Compare September 28, 2023 09:04
@marseel
Copy link
Contributor Author

marseel commented Sep 28, 2023

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Sep 29, 2023
@aanm aanm merged commit 312ad0d into cilium:main Sep 29, 2023
60 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aditighag aditighag aditighag left review comments

@kaworu kaworu kaworu approved these changes

@zacharysarah zacharysarah zacharysarah approved these changes

@tommyp1ckles tommyp1ckles tommyp1ckles approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@marseel @kaworu @zacharysarah @tommyp1ckles @aditighag @aanm