Delete auth map entries of deleted SVID #27663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
meyskens
added
the
release-note/minor
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
meyskens
added
area/servicemesh
meyskens
force-pushed
the
meyskens/signal-spire-cert-delete
branch
from
edb60dd
to
4365e14
Compare
|
/test |
youngnick
approved these changes
Sep 5, 2023
|
/test |
meyskens
force-pushed
the
meyskens/signal-spire-cert-delete
branch
from
4365e14
to
ced4bc9
Compare
This change adds a watcher on the SPIRE updates for deleted SVIDs. If one is deleted it will be signaled over the rotation channel. Should the ID be present in the auth map it will be immediately removed. Signed-off-by: Maartje Eyskens <maartje.eyskens@isovalent.com>
meyskens
force-pushed
the
meyskens/signal-spire-cert-delete
branch
from
ced4bc9
to
f6e2eb2
Compare
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
|
Is this really |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a watcher on the SPIRE updates for deleted SVIDs. If one is deleted it will be signaled over the rotation channel. Should the ID be present in the auth map it will be immediately removed.