-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Clarify ClusterMesh troubleshooting steps when KVStoreMesh is enabled #27691
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs structure OK, but someone from @cilium/sig-clustermesh please review the content.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me content wise. I know that there's some ongoing effort to revamp the clustermesh troubleshooting guide, but this improvement is definitely worth.
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@weizhoublue Could you maybe update the CODEOWNERS file to add sig-clustermesh as an owner of the docs you changed? That is:
Documentation/operations/troubleshooting_clustermesh.rst @cilium/sig-clustermesh @cilium/docs-structure
But it's only tangentially related to the change, so it's fine to merge the change as is IMO.
4403432
to
fd79789
Compare
my pleasure, and updated |
/test |
the PR seems to have no business failing the connectivity test of the check |
@weizhoublue yeah, the CI fail seems completely unrelated, it shouldn't block the merge I think |
fd79789
to
a8930b3
Compare
/test |
a8930b3
to
7f672fc
Compare
some connectivity case failed, I try to rebase again |
/test |
@weizhoublue It was probably a flake, don't worry about it. The checks relevant to your change passed, so once there is an approve from |
thanks |
@weizhoublue It looks like this PR needs to be rebased to pick the latest CI changes |
Signed-off-by: weizhou.lan@daocloud.io <weizhou.lan@daocloud.io>
7f672fc
to
5a4a4a9
Compare
ok |
/test |
when the KVStoreMesh is on, I find the debug steps are not in line with the facts, the
hostAliases
does not exist in Cilium DaemonSet, but exist in the clustermesh-apiserver deploymentthe chart code
and the remote cluster address does not exist in the secret
cilium-clustermesh
, but exist in the secretcilium-kvstoremesh