Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.13 Backports 2023-08-28 #27741

Merged
merged 4 commits into from
Sep 1, 2023
Merged

v1.13 Backports 2023-08-28 #27741

merged 4 commits into from
Sep 1, 2023

Commits on Aug 31, 2023

  1. proxy: Ignore visibility annotation if proxy is disabled 

    [ upstream commit fe37586 ]

This is to avoid the below error if proxy is disabled as part of
installation, but the visibility annotation is added to pods later.

```
2023-08-11T12:42:41.390575371Z goroutine 1522 [running]:
2023-08-11T12:42:41.390581994Z github.com/cilium/cilium/pkg/proxy.(*Proxy).CreateOrUpdateRedirect(0x0, {0x3ae74b8, 0xc000650280}, {0x3aeb440?, 0xc0016e4560?}, {0xc0010ba1b0, 0x12}, {0x3afd260, 0xc000982000}, 0xc001c9c980)
2023-08-11T12:42:41.390589198Z  github.com/cilium/cilium/pkg/proxy/proxy.go:459 +0xb7
2023-08-11T12:42:41.390596081Z github.com/cilium/cilium/pkg/endpoint.(*Endpoint).addVisibilityRedirects(0xc000982000, 0x1, 0xc001874ba0?, 0xc001c9c980?)
2023-08-11T12:42:41.390602613Z  github.com/cilium/cilium/pkg/endpoint/bpf.go:343 +0x443
2023-08-11T12:42:41.390614345Z github.com/cilium/cilium/pkg/endpoint.(*Endpoint).addNewRedirects(0xc000982000, 0xc001874870?)
2023-08-11T12:42:41.390651325Z  github.com/cilium/cilium/pkg/endpoint/bpf.go:424 +0x3c5
2023-08-11T12:42:41.390658068Z github.com/cilium/cilium/pkg/endpoint.(*Endpoint).runPreCompilationSteps(0xc000982000, 0xc000e31800, 0x0)
2023-08-11T12:42:41.390663999Z  github.com/cilium/cilium/pkg/endpoint/bpf.go:802 +0x4fe
2023-08-11T12:42:41.390669690Z github.com/cilium/cilium/pkg/endpoint.(*Endpoint).regenerateBPF(0xc000982000, 0xc000e31800)
2023-08-11T12:42:41.390675451Z  github.com/cilium/cilium/pkg/endpoint/bpf.go:542 +0x1a5
2023-08-11T12:42:41.390681112Z github.com/cilium/cilium/pkg/endpoint.(*Endpoint).regenerate(0xc000982000, 0xc000e31800)
2023-08-11T12:42:41.390686893Z  github.com/cilium/cilium/pkg/endpoint/policy.go:467 +0x9c6
2023-08-11T12:42:41.390692564Z github.com/cilium/cilium/pkg/endpoint.(*EndpointRegenerationEvent).Handle(0xc000131b50, 0x0?)
2023-08-11T12:42:41.390698385Z  github.com/cilium/cilium/pkg/endpoint/events.go:53 +0x325
2023-08-11T12:42:41.390704045Z github.com/cilium/cilium/pkg/eventqueue.(*EventQueue).run.func1()
2023-08-11T12:42:41.390709716Z  github.com/cilium/cilium/pkg/eventqueue/eventqueue.go:245 +0x142
```

Fixes: #27594

Signed-off-by: Tam Mach <tam.mach@cilium.io>
Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
    @sayboras @pippolo84
    sayboras authored and pippolo84 committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    6eb388c View commit details
    Browse the repository at this point in the history

  2. helm: Add validation rule for Envoy L7 Load Balancer 

    [ upstream commit 3f23ba7 ]

This is to ensure that proxy must be enabled if Envoy L7 Load balancer
feature is enabled.

Signed-off-by: Tam Mach <tam.mach@cilium.io>
Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
    @sayboras @pippolo84
    sayboras authored and pippolo84 committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    5e7e5c4 View commit details
    Browse the repository at this point in the history

  3. ci-ipsec-upgrade: Skip upon test/Documentation changes 

    [ upstream commit 9389b2c ]

Reported-by: Joe Stringer <joe@cilium.io>
Signed-off-by: Martynas Pumputis <m@lambda.lt>
Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
    @brb @pippolo84
    brb authored and pippolo84 committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    07212f7 View commit details
    Browse the repository at this point in the history

  4. ci: rename name fields 

    [ upstream commit e9e43fe ]

This commit changes workflow's name fields to
make them more human readable by adding spaces.
Also some of the names was changed to be more consistent with each other

Signed-off-by: Birol Bilgin <birol@cilium.io>
Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
    @brlbil @pippolo84
    brlbil authored and pippolo84 committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    46a69f5 View commit details
    Browse the repository at this point in the history