cilium/cmd: make output of 'cilium policy selectors' sorted. #27803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommyp1ckles
added
release-note/minor
|
/test |
|
Minor nit: I'd consider this API unstable, but I think you're communicating that the output should be sorted. I agree with that :-) |
tommyp1ckles
force-pushed
the
pr/tp/make-selector-output-stable
branch
from
f63cacb
to
e6c4117
Compare
|
/test |
tommyp1ckles
force-pushed
the
pr/tp/make-selector-output-stable
branch
from
e6c4117
to
4c979a1
Compare
|
/test |
tommyp1ckles
changed the title
|
@joestringer updated commit so people don't get the wrong idea |
Previously, the output would be sent in no particular order, thus when running the 'policy selectors' command output would often be printed in different order. This makes it hard to compare subsequent outputs. This PR simply sorts output by selector string before it is printed to make the ordering stable. Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
tommyp1ckles
force-pushed
the
pr/tp/make-selector-output-stable
branch
from
4c979a1
to
1432279
Compare
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the output would be sent in no particular order, thus when running the 'policy selectors' command output would often be printed in different order. This makes it hard to compare subsequent outputs.
This PR simply sorts output by selector string before it is printed to make the ordering stable.