Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: regenerate flow.pb.go #27852

Merged
merged 2 commits into from
Sep 13, 2023
Merged

api: regenerate flow.pb.go #27852

merged 2 commits into from
Sep 13, 2023

Conversation

Jack-R-lantern
Copy link
Contributor

@Jack-R-lantern Jack-R-lantern commented Aug 31, 2023 •
edited

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request

  • All code is covered by unit and/or runtime tests where feasible.

  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.

  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.

  • All commits are signed off. See the section Developer’s Certificate of Origin

  • Provide a title or release-note blurb suitable for the release notes.

  • Are you a user of Cilium? Please add yourself to the Users doc

  • Thanks for contributing!

  • add DebugEventType DBG_L7_LB, DBG_SKIP_POLICY

  • regenerate flow.pb.go

Fixes: #27826

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 31, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Aug 31, 2023
@Jack-R-lantern Jack-R-lantern marked this pull request as ready for review August 31, 2023 16:09
@Jack-R-lantern Jack-R-lantern requested review from a team as code owners August 31, 2023 16:09
@rolinh rolinh added the release-note/misc This PR makes changes that have no direct user impact. label Sep 1, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 1, 2023
gandro
gandro requested changes Sep 4, 2023
View reviewed changes
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I don't fully understand the motivation for the second change

bpf/lib/dbg.h Outdated Show resolved Hide resolved
@Jack-R-lantern Jack-R-lantern force-pushed the ISSUE-27826/Add-cilium_dbg-statement-to-ipv4_to_endpoint_is_hairpin_flow branch 2 times, most recently from 7735bc8 to 941f2c7 Compare September 4, 2023 13:49
gandro
gandro approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gandro
Copy link
Member

gandro commented Sep 4, 2023

It seems something went wrong with GitHub. Let's see if closing and opening the PR fixes it.

 Download action repository 'actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744' (SHA:f43a0e5ff2bd294095638e18286ca9a3d1956744)
Error: Can't use 'tar -xzf' extract archive file: /home/runner/work/_actions/_temp_5842cc54-fb27-4f25-a9e1-b9951ccc0495/eeeb8f1d-2d84-4ac2-bd35-0c5c9472cd27.tar.gz. return code: 2.

@gandro gandro closed this Sep 4, 2023
@gandro gandro reopened this Sep 4, 2023
@Jack-R-lantern Jack-R-lantern force-pushed the ISSUE-27826/Add-cilium_dbg-statement-to-ipv4_to_endpoint_is_hairpin_flow branch from 941f2c7 to 412b75d Compare September 5, 2023 14:31
@Jack-R-lantern
Copy link
Contributor Author

@gandro #27798 is merged so I think A is a good choice. I'll fix #27826 in this PR,
so I want to change it to draft pr, but I don't have permissions, is it possible to change it?

@gandro gandro marked this pull request as draft September 5, 2023 16:01
@gandro
Copy link
Member

gandro commented Sep 5, 2023

@gandro #27798 is merged so I think A is a good choice. I'll fix #27826 in this PR, so I want to change it to draft pr, but I don't have permissions, is it possible to change it?

Sure, I've converted it to a draft PR!

@Jack-R-lantern Jack-R-lantern force-pushed the ISSUE-27826/Add-cilium_dbg-statement-to-ipv4_to_endpoint_is_hairpin_flow branch from 3caec78 to fddd8f8 Compare September 6, 2023 12:08
@Jack-R-lantern Jack-R-lantern marked this pull request as ready for review September 6, 2023 12:12
@Jack-R-lantern Jack-R-lantern force-pushed the ISSUE-27826/Add-cilium_dbg-statement-to-ipv4_to_endpoint_is_hairpin_flow branch from fddd8f8 to 8f7394f Compare September 6, 2023 13:15
gandro
gandro approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hubble related changes look good to me, thanks!

@gandro
Copy link
Member

gandro commented Sep 6, 2023

Image build failed due to some GitHub infra error. Closing and re-opening the PR to restart it.

@gandro gandro closed this Sep 6, 2023
@gandro gandro reopened this Sep 6, 2023
@gandro gandro added the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label Sep 12, 2023
@gandro
Copy link
Member

gandro commented Sep 12, 2023

This unfortunately needs a rebase now

@Jack-R-lantern Jack-R-lantern force-pushed the ISSUE-27826/Add-cilium_dbg-statement-to-ipv4_to_endpoint_is_hairpin_flow branch from 8f7394f to 818c290 Compare September 12, 2023 13:45
@Jack-R-lantern
api: regenerate flow.pb.go
910c00d 
- add DebugEventType DBG_L7_LB, DBG_SKIP_POLICY
- regenerate flow.pb.go
- add bpf/lib/dbg.h Trace types DBG_SKIP_POLICY

Signed-off-by: Jack-R-lantern <tjdfkr2421@gmail.com>
@Jack-R-lantern
datapath: add cilium_dbg in tail_ipv4_to_endpoint
f2fd305 
This commit add cilium_dbg for locally hairpinned packet

Signed-off-by: Jack-R-lantern <tjdfkr2421@gmail.com>
@Jack-R-lantern Jack-R-lantern force-pushed the ISSUE-27826/Add-cilium_dbg-statement-to-ipv4_to_endpoint_is_hairpin_flow branch from 818c290 to f2fd305 Compare September 12, 2023 13:50
@Jack-R-lantern
Copy link
Contributor Author

@gandro i rebased

@gandro
Copy link
Member

gandro commented Sep 12, 2023 •
edited

/test

Edit: ci-ipsec-upgrade hit #27827

@gandro gandro removed the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label Sep 12, 2023
@gandro
Copy link
Member

gandro commented Sep 13, 2023 •
edited

Required CI passed. @ldelossa PTAL as assigned reviewer

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Sep 13, 2023
@julianwiedmann julianwiedmann added the area/monitor Impacts monitoring, access logging, flow logging, visibility of datapath traffic. label Sep 13, 2023
@julianwiedmann julianwiedmann merged commit ff154af into cilium:main Sep 13, 2023
59 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@rolinh rolinh rolinh approved these changes

@ldelossa ldelossa ldelossa approved these changes

Assignees
No one assigned
Labels
area/monitor Impacts monitoring, access logging, flow logging, visibility of datapath traffic. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add cilium_dbg statement to ipv4_to_endpoint_is_hairpin_flow()
5 participants
@Jack-R-lantern @gandro @rolinh @ldelossa @julianwiedmann