Correlate flows with CiliumNetworkPolicies #27854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chancez
added
kind/feature
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
|
/test |
michi-covalent
added
the
release-note/minor
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
michi-covalent
approved these changes
Aug 31, 2023
There was a problem hiding this comment.
lgtm for the files owned by hubble team, just some minor suggestions / questions.
i'll add do-not-merge label. i'd like to get this reviewed by @gandro 🙏
michi-covalent
added
the
dont-merge/discussion
chancez
force-pushed
the
pr/chancez/hubble_policy_metadata_oss
branch
from
bac754b
to
0aee000
Compare
gandro
requested changes
Sep 4, 2023
chancez
force-pushed
the
pr/chancez/hubble_policy_metadata_oss
branch
from
0aee000
to
f060504
Compare
|
/test |
rolinh
approved these changes
Sep 6, 2023
michi-covalent
removed
the
dont-merge/discussion
nathanjsweet
requested changes
Sep 7, 2023
chancez
force-pushed
the
pr/chancez/hubble_policy_metadata_oss
branch
from
f060504
to
438e764
Compare
Using GetRealizedPolicyRuleLabelsForKey, lookup policy labels for a flow using the: direction, endpointIP, remoteIdentity, protocool and destination port. After getting the labels, reconstruct the policy name and namespace using the well-known policy labels. Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
chancez
force-pushed
the
pr/chancez/hubble_policy_metadata_oss
branch
from
438e764
to
cd9b4d4
Compare
nathanjsweet
approved these changes
Sep 7, 2023
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using GetRealizedPolicyRuleLabelsForKey, lookup policy labels for a flow using the: direction, endpointIP, remoteIdentity, protocool and destination port. After getting the labels, reconstruct the policy name and namespace using the well-known policy labels.
Relates to cilium/hubble#1100
Closes #26438.
Reviewers note: The protobuf field numbers may look arbitrary, however, this is a port of a feature we maintained internally, so for compatibility, it would be ideal to reuse the existing protobuf field names and numbers.