egressgw: switch unit tests to reconciliationEventsCount #27881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jibi
added
release-note/ci
jibi
force-pushed
the
pr/jibi/egressgw-reconciliation-counter
branch
from
8007ff0
to
fd5b0b4
Compare
this commit introduces a new manager variable, reconciliationEventsCount, used to track how many reconciliation events have occoured. This will be used in a subsequent commit to improve unit tests, ensuring assertions only happen after a reconciliation has actually been performed. Signed-off-by: Gilberto Bertin <jibi@cilium.io>
jibi
force-pushed
the
pr/jibi/egressgw-reconciliation-counter
branch
from
fd5b0b4
to
172ffee
Compare
jibi
commented
Sep 1, 2023
instead of just retrying to assert that egressgw bpf entries and IP rules/routes are consistent with the expected state, use the newly introduced reconciliationEventsCount manager's variable to ensure that the manager has actually gone through a reconciliation round Signed-off-by: Gilberto Bertin <jibi@cilium.io>
jibi
force-pushed
the
pr/jibi/egressgw-reconciliation-counter
branch
from
172ffee
to
0e8f243
Compare
|
/test |
jibi
added
the
needs-backport/1.14
jibi
removed
the
needs-backport/1.14
jibi
added
backport/author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of just retrying to assert that egressgw bpf entries and IP
rules/routes are consistent with the expected state, use the newly
introduced reconciliationEventsCount manager's variable to ensure that
the manager has actually gone through a reconciliation round