external-workloads: do not automatically infer ClusterID/Name #27886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giorio94
added
release-note/minor
gandro
reviewed
Sep 4, 2023
giorio94
force-pushed
the
mio/external-worklods-cluster-id-name
branch
from
45695eb
to
32514e8
Compare
External workloads are marked as a beta feature, but I agree that it makes sense to call this out as a breaking change. I've updated the upgrade notes to document it. |
|
/test |
giorio94
force-pushed
the
mio/external-worklods-cluster-id-name
branch
from
32514e8
to
c7e3f02
Compare
gandro
approved these changes
Sep 18, 2023
giorio94
force-pushed
the
mio/external-worklods-cluster-id-name
branch
from
c7e3f02
to
69718e3
Compare
|
/test |
zacharysarah
requested changes
Sep 25, 2023
There was a problem hiding this comment.
@giorio94 Thanks for your patience. This is well-written and needs only some small tweaks for approval.
Currently, when the Cilium agent running on a VM joins an existing cluster, it automatically infers the corresponding ClusterID and ClusterName. Yet, this introduces a dependency order, because all consumers of that field need to be initialized after the connection to the remote cluster, which is especially problematic as more components get converted to cells. Additionally, this may also lead to possible user confusion, as the corresponding parameter is reported as not initialized in the logs. Hence, let's require these parameters to be explicitly set, reporting a failure in case they don't match those automatically discovered. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
giorio94
force-pushed
the
mio/external-worklods-cluster-id-name
branch
from
69718e3
to
ccc895f
Compare
Thanks @zacharysarah for the feedback, I've applied your suggestion. |
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when the Cilium agent running on a VM joins an existing cluster, it automatically infers the corresponding ClusterID and ClusterName. Yet, this introduces a dependency order, because all consumers of that field need to be initialized after the connection to the remote cluster, which is especially problematic as more components get converted to cells. Additionally, this may also lead to possible user confusion, as the corresponding parameter is reported as not initialized in the logs.
Hence, let's require these parameters to be explicitly set, reporting a failure in case they don't match those automatically discovered.
Depends on cilium/cilium-cli#1948