Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/l2announcer: Adds Service LoadBalancerClass Support #27976

Merged
merged 3 commits into from
Sep 13, 2023
Merged

pkg/l2announcer: Adds Service LoadBalancerClass Support #27976

merged 3 commits into from
Sep 13, 2023

Conversation

danehans
Copy link
Contributor

@danehans danehans commented Sep 6, 2023 •
edited
Loading

  • Adds L2AnnounceLoadBalancerClass constant to define the load balancer class supported by the L2 Announcer.
  • Updates upsertSvc() to check the load balancer class of the provided service.
  • Updates the ServiceSelector godocs to reflect the new API behavior.
  • Updates operator LB IPAM pkg to support L2 Announcer LB class.
  • Adds unit tests.

Fixes: #26556

CiliumL2AnnouncementPolicy will only select Services that do not specify a LoadBalancerClass or specify a LoadBalancerClass of "io.cilium/l2-announcer".

@danehans danehans requested review from a team as code owners September 6, 2023 18:32
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 6, 2023
@danehans danehans requested a review from a team as a code owner September 6, 2023 18:54
@danehans
Copy link
Contributor Author

danehans commented Sep 6, 2023

/test

@danehans
Copy link
Contributor Author

danehans commented Sep 7, 2023

/cc @dylandreimerink

dylandreimerink
dylandreimerink approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@dylandreimerink dylandreimerink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this. Looks good to me

@dylandreimerink dylandreimerink added kind/enhancement This would improve or streamline existing functionality. release-note/minor This PR changes functionality that users may find relevant to operating Cilium. feature/l2-announcement labels Sep 8, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Sep 8, 2023
@danehans
pkg/l2announcer: Adds Service LoadBalancerClass Support
4bc1ab2 
- Adds L2AnnounceLoadBalancerClass constant to define the load balancer
  class supported by the L2 Announcer.
- Updates upsertSvc() to check the load balancer class of the provided
  service.
- Adds unit tests.

Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
@danehans
operator: Updates LB IPAM to Support L2 Announcer LB Class
aafb5e0 
Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
@danehans
daemon: Updates Detect() scope to return detected devices
11df53a 
Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
@danehans
Copy link
Contributor Author

/test

@danehans
Copy link
Contributor Author

/ci-aks

@danehans
Copy link
Contributor Author

CI is passing, @dylandreimerink @nathanjsweet do you have any recommendations for other maintainers to review and merge?

@dylandreimerink dylandreimerink merged commit 7a6b63e into cilium:main Sep 13, 2023
61 checks passed
@danehans danehans mentioned this pull request Sep 20, 2023
Closed
@danehans danehans deleted the issue_26556_l2_announce branch March 8, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanjsweet nathanjsweet nathanjsweet approved these changes

@dylandreimerink dylandreimerink dylandreimerink approved these changes

@meyskens meyskens Awaiting requested review from meyskens meyskens is a code owner automatically assigned from cilium/sig-agent

@ysksuzuki ysksuzuki Awaiting requested review from ysksuzuki ysksuzuki is a code owner automatically assigned from cilium/sig-lb

Assignees
No one assigned
Labels
feature/l2-announcement kind/enhancement This would improve or streamline existing functionality. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

L2-announcements and BGP compatibility
3 participants
@danehans @nathanjsweet @dylandreimerink