-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add conformance-ginkgo-race #27979
base: main
Are you sure you want to change the base?
Conversation
cc72017
to
28ce2f8
Compare
28ce2f8
to
979dd0c
Compare
979dd0c
to
87a6ac2
Compare
Copy/pasting comment from previous PR:
|
87a6ac2
to
4b427f5
Compare
4b427f5
to
9e4d120
Compare
Keeping this in draft until we have passing workflows :) |
bec8701
to
60a7e0b
Compare
/ci-ginkgo-race |
60a7e0b
to
21e7db1
Compare
[ upstream commit fb6bd90 ] PR #25309 introduced a data race by sharing the sessionUDPFactory between the DNS server instances for the different IP families (IPv4 & IPv6). This has been detected by #27979. This commit fixes the data race by using dedicated instances of the sessionUDPFactory. Fixes: #28156 Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com> Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
[ upstream commit f73e1c5 ] [ backporter's notes: switched cilium/dns import to miekg/dns, as v1.14 was relying on a replace directive instead of pointing to the fork. ] PR #25309 introduced a data race by sharing the sessionUDPFactory between the DNS server instances for the different IP families (IPv4 & IPv6). This has been detected by #27979. This commit fixes the issue for the TCP servers too. It not set explicitly, these are initialized with the default udp session factory to prevent nil pointer exceptions. Therefore, an explicit noop udp session factory is set. Fixes: #28156 Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com> Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
/ci-ginkgo-race |
1506f83
to
6ebc9c9
Compare
/ci-ginkgo-race |
bacd82b
to
34a083b
Compare
/ci-ginkgo-race |
34a083b
to
4a490e7
Compare
/ci-ginkgo-race |
[ upstream commit fb6bd90 ] PR cilium#25309 introduced a data race by sharing the sessionUDPFactory between the DNS server instances for the different IP families (IPv4 & IPv6). This has been detected by cilium#27979. This commit fixes the data race by using dedicated instances of the sessionUDPFactory. Fixes: cilium#28156 Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com> Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
[ upstream commit f73e1c5 ] [ backporter's notes: switched cilium/dns import to miekg/dns, as v1.14 was relying on a replace directive instead of pointing to the fork. ] PR cilium#25309 introduced a data race by sharing the sessionUDPFactory between the DNS server instances for the different IP families (IPv4 & IPv6). This has been detected by cilium#27979. This commit fixes the issue for the TCP servers too. It not set explicitly, these are initialized with the default udp session factory to prevent nil pointer exceptions. Therefore, an explicit noop udp session factory is set. Fixes: cilium#28156 Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com> Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
4a490e7
to
8603059
Compare
/ci-ginkgo-race |
1 similar comment
/ci-ginkgo-race |
ae1e57d
to
a62b295
Compare
a62b295
to
d147936
Compare
This commit introduces a new workflow for running the ginkgo test suite with race detection enabled. The goal is to start this effort by doing a copy and paste of the existing ginkgo workflow and modifying it as needed. In the future, effort will be put towards reducing this duplication. Thank you to @markpash for getting this started. Fixes: #26170 Signed-off-by: Ryan Drew <ryan.drew@isovalent.com>
d147936
to
d613507
Compare
This pull request has been automatically marked as stale because it |
/ci-ginkgo-race |
This commit introduces a new workflow for running the ginkgo test suite with race detection enabled. The goal is to start this effort by doing a copy and paste of the existing ginkgo workflow and modifying it as needed. In the future, effort will be put towards reducing this duplication.
Thank you to @markpash for getting this started.
Fixes: #26170
Supersedes #27797.
Here is the diff between
conformance-ginkgo-race
andconformance-ginkgo
: