Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

daemon: Fix boostrap restore duration metric #27983

Merged
merged 1 commit into from
Sep 27, 2023
Merged

daemon: Fix boostrap restore duration metric #27983

merged 1 commit into from
Sep 27, 2023

Conversation

PlatformLC
Copy link
Contributor

The start timestamp update for 'restoreOldEndpoints' is missed for bootstrap stats calculation.

Fix inaccurate calculation for bootstrap stats of restore

@PlatformLC PlatformLC requested a review from a team as a code owner September 7, 2023 05:33
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 7, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Sep 7, 2023
@PlatformLC
Copy link
Contributor Author

/test

@maintainer-s-little-helper
Copy link

Commit 0d44410fa75861074dae1842bbb0f2f45918dd5c does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Sep 8, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Sep 8, 2023
@PlatformLC PlatformLC force-pushed the bugfix/restore_stats branch 2 times, most recently from 0541506 to 089430e Compare September 12, 2023 00:42
@thorn3r
Copy link
Contributor

thorn3r commented Sep 13, 2023

/test

thorn3r
thorn3r approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@thorn3r thorn3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, thanks! looks good 👍

@PlatformLC
Copy link
Contributor Author

/test

@PlatformLC
Copy link
Contributor Author

/test

@PlatformLC PlatformLC force-pushed the bugfix/restore_stats branch 2 times, most recently from 670c677 to ef15269 Compare September 21, 2023 02:44
@PlatformLC
Copy link
Contributor Author

/test

@PlatformLC
Copy link
Contributor Author

/ci-ipsec-upgrade

@PlatformLC
Copy link
Contributor Author

Hi @thorn3r, how could I remove the label dont-merge/needs-release-note-label? I've already added a release note in description following the PR template.

@PlatformLC PlatformLC mentioned this pull request Sep 24, 2023
Merged
@lmb lmb added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Sep 26, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 26, 2023
@lmb lmb added area/daemon Impacts operation of the Cilium daemon. sig/agent Cilium agent related. labels Sep 26, 2023
@lmb
Copy link
Contributor

lmb commented Sep 26, 2023

@PlatformLC the label is removed as soon as one of the release-notes/* labels is added to the issue by one of the Cilium team members. See point 11. at https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#submitting-a-pull-request

@PlatformLC
Copy link
Contributor Author

@PlatformLC the label is removed as soon as one of the release-notes/* labels is added to the issue by one of the Cilium team members. See point 11. at https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#submitting-a-pull-request

Got it, thx for clarifying it!

@PlatformLC
daemon: Fix boostrap restore duration metric
632337c 
The start timestamp update for 'restoreOldEndpoints' is missed for bootstrap
stats calculation.

Signed-off-by: Li Chun <chun2.li@intel.com>
@lmb
Copy link
Contributor

lmb commented Sep 27, 2023

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Sep 27, 2023
@lmb lmb merged commit 4d485a9 into cilium:main Sep 27, 2023
59 of 61 checks passed
@PlatformLC PlatformLC deleted the bugfix/restore_stats branch October 7, 2023 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thorn3r thorn3r thorn3r approved these changes

Assignees
No one assigned
Labels
area/daemon Impacts operation of the Cilium daemon. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium. sig/agent Cilium agent related.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PlatformLC @thorn3r @lmb