Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BGP CP: Calls String() Afi/Safi Methods instead of Duplicative Funcs #28035

Merged
merged 1 commit into from
Sep 14, 2023
Merged

BGP CP: Calls String() Afi/Safi Methods instead of Duplicative Funcs #28035

merged 1 commit into from
Sep 14, 2023

Conversation

danehans
Copy link
Contributor

@danehans danehans commented Sep 8, 2023

Removes duplicative ToAPIAfi() and ToAPISafi() functions in favor of using the Afi/Safi String() method.

@danehans
BGP CP: Calls String() Afi/Safi Methods instead of Duplicative Funcs
5f31a64 
Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
@danehans danehans requested a review from a team as a code owner September 8, 2023 17:43
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 8, 2023
@danehans
Copy link
Contributor Author

/test

@rastislavs rastislavs mentioned this pull request Sep 11, 2023
Merged
@rastislavs rastislavs added the release-note/misc This PR makes changes that have no direct user impact. label Sep 11, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 11, 2023
@rastislavs rastislavs added kind/cleanup This includes no functional changes. area/bgp labels Sep 11, 2023
@danehans
Copy link
Contributor Author

The Cilium IPsec upgrade job is failing due to #28088.

@danehans
Copy link
Contributor Author

/ci-ipsec-upgrade

@danehans
Copy link
Contributor Author

The Cilium IPsec upgrade job is still failing due to flake: #28088.

rastislavs
rastislavs approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@rastislavs rastislavs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Sep 14, 2023
@julianwiedmann julianwiedmann merged commit b41edf3 into cilium:main Sep 14, 2023
61 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rastislavs rastislavs rastislavs approved these changes

Assignees
No one assigned
Labels
area/bgp kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danehans @rastislavs @julianwiedmann