cni: use case-insensitive names for CNI chaining mode #28050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow case-insensitive names for CNI chaining mode Upon startup, Cilium must write CNI config files for the configured chaining mode. For this purpose, it uses a package-scoped map with lowercase string keys to refer to each mode. We have seen configurations in the wild which do not use all-lowercase names for these chaining modes. For example, in the reccomended configuration for OpenShift conformance testing we have: cni.chainingMode=portMap This causes Cilium to fail on startup with: failed to render CNI configuration file: invalid CNI chaining mode: portMap Signed-off-by: Andrew Sauber <2046750+asauber@users.noreply.github.com>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
asauber
added
the
release-note/minor
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
ldelossa
approved these changes
Sep 11, 2023
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow case-insensitive names for CNI chaining mode
Upon startup, Cilium must write CNI config files for the configured chaining mode. For this purpose, it uses a package-scoped map with lowercase string keys to refer to each mode.
We have seen configurations in the wild which do not use all-lowercase names for these chaining modes. For example, in the reccomended configuration for OpenShift conformance testing we have:
This causes Cilium to fail on startup with: