-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helm: add jobLabel to cilium-{agent,operator} and hubble serviceMonitor #28125
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rbankston, thanks for opening this PR!
Please add the jobLabel values to install/kubernetes/cilium/values.yaml.tmpl
along with a doc comment above them, and then run make -C install/kubernetes cilium/values.yaml && make -C Documentation update-helm-values
.
Hello @kaworu Thank you for that information. I've done those steps and squashed to a single commit. |
Commit df32a8ca7b050dbba9f0fa11e275edc471e58f5f does not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update @rbankston
- Check patch is complaining about the commit's long title, can you rephrase it under 75 characters? e.g.
helm: add jobLabel to cilium-{agent,operator} and hubble serviceMonitor
- Please run
make -C install/kubernetes
to make Helm Check happy - Please run
make -C Documentation update-helm-values
to make Travis-CI happy - Finally, rebase on top of
main
and squash everything into a single commit 🙏
install/kubernetes/cilium/templates/cilium-agent/servicemonitor.yaml
Outdated
Show resolved
Hide resolved
install/kubernetes/cilium/templates/cilium-operator/servicemonitor.yaml
Outdated
Show resolved
Hide resolved
Commit 37805298d69e927ee9c5dc677b307193f23dce95 does not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
Commit 37805298d69e927ee9c5dc677b307193f23dce95 does not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question, other than that Helm changes LGTM.
Signed-off-by: Ralph Bankston <ralph.bankston@isovalent.com>
/test |
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXX
line if the commit addresses a particularGitHub issue.
Fixes: <commit-id>
tag, thenplease add the commit author[s] as reviewer[s] to this issue.
Adds optional configurable jobLabel to cilium-agent, cilium-operator, and hubble serviceMonitors
Defaults to disabled and without existence does not alter the helm template.