Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: add jobLabel to cilium-{agent,operator} and hubble serviceMonitor #28125

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

rbankston
Copy link
Contributor

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

Adds optional configurable jobLabel to cilium-agent, cilium-operator, and hubble serviceMonitors
Defaults to disabled and without existence does not alter the helm template.

Adds optional configurable jobLabel to cilium-agent, cilium-operator, and hubble serviceMonitors

@rbankston rbankston requested review from a team as code owners September 12, 2023 18:22
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 12, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Sep 12, 2023
Copy link
Member

@kaworu kaworu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rbankston, thanks for opening this PR!

Please add the jobLabel values to install/kubernetes/cilium/values.yaml.tmpl along with a doc comment above them, and then run make -C install/kubernetes cilium/values.yaml && make -C Documentation update-helm-values.

@kaworu kaworu added kind/enhancement This would improve or streamline existing functionality. release-note/minor This PR changes functionality that users may find relevant to operating Cilium. area/helm Impacts helm charts and user deployment experience labels Sep 14, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 14, 2023
@rbankston
Copy link
Contributor Author

Hello @kaworu Thank you for that information. I've done those steps and squashed to a single commit.

@maintainer-s-little-helper
Copy link

Commit df32a8ca7b050dbba9f0fa11e275edc471e58f5f does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Sep 18, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Sep 18, 2023
Copy link
Member

@kaworu kaworu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @rbankston

  1. Check patch is complaining about the commit's long title, can you rephrase it under 75 characters? e.g. helm: add jobLabel to cilium-{agent,operator} and hubble serviceMonitor
  2. Please run make -C install/kubernetes to make Helm Check happy
  3. Please run make -C Documentation update-helm-values to make Travis-CI happy
  4. Finally, rebase on top of main and squash everything into a single commit 🙏

@rbankston rbankston changed the title Adds jobLabel helm options to serviceMonitor of cilium-agent, cilium-operator, and hubble components helm: add jobLabel to cilium-{agent,operator} and hubble serviceMonitor Sep 27, 2023
@maintainer-s-little-helper
Copy link

Commit 37805298d69e927ee9c5dc677b307193f23dce95 does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Sep 27, 2023
@maintainer-s-little-helper
Copy link

Commit 37805298d69e927ee9c5dc677b307193f23dce95 does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

Copy link
Member

@kaworu kaworu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, other than that Helm changes LGTM.

Signed-off-by: Ralph Bankston <ralph.bankston@isovalent.com>
@joamaki
Copy link
Contributor

joamaki commented Oct 6, 2023

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 6, 2023
@ti-mo ti-mo merged commit 4b980e1 into cilium:main Oct 6, 2023
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm Impacts helm charts and user deployment experience kind/community-contribution This was a contribution made by a community member. kind/enhancement This would improve or streamline existing functionality. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants