endpointmanager: fix bpf policy pressure getting stuck. #28185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
tommyp1ckles
added
release-note/bug
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
christarazi
requested changes
Sep 18, 2023
tommyp1ckles
force-pushed
the
pr/tp/fix-policy-map-pressure-max
branch
from
82aa9c9
to
05aa798
Compare
|
/test |
tommyp1ckles
force-pushed
the
pr/tp/fix-policy-map-pressure-max
branch
from
05aa798
to
3f73d45
Compare
|
/test |
tommyp1ckles
force-pushed
the
pr/tp/fix-policy-map-pressure-max
branch
from
3f73d45
to
efd638c
Compare
|
/test |
christarazi
approved these changes
Sep 28, 2023
|
This pull request has been automatically marked as stale because it |
github-actions
bot
added
the
stale
|
Let's get this PR over the finish line @tommyp1ckles, it's basically there. Just some Go linter errors to fix up. |
github-actions
bot
removed
the
stale
|
@christarazi woops yeah forgot about this one, let me get it ready |
tommyp1ckles
force-pushed
the
pr/tp/fix-policy-map-pressure-max
branch
from
efd638c
to
9e3890a
Compare
|
/test |
Currently the policy map pressure metric only updates the map pressure metric when a new pressure value that is higher than the current one is set. This means that the metric can only ever go up, so when maps are shrunk (ex. such as after doing an cilium fqdn cache clean) the metric never goes down. This changes the behavior of the metric to maintain a map of map pressure values. When the trigger is invoked, it iterates all values and finds the max - updating the map_pressure gauge for policymaps to the max value. Endpoints that are shut down have their values removed. Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
tommyp1ckles
force-pushed
the
pr/tp/fix-policy-map-pressure-max
branch
from
9e3890a
to
5bf6820
Compare
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the policy map pressure metric only updates the map pressure metric when a new pressure value that is higher than the current one is set. This means that the metric can only ever go up, so when maps are shrunk (ex. such as after doing an cilium fqdn cache clean) the metric never goes down.
This changes the behaviour of the metric to maintain a map of map pressure values. When the trigger is invoked, it iterates all values and finds the max - updating the map_pressure gauge for policymaps to the max value. Endpoints that are shut down have their values removed.
CC: @christarazi
Note: This is part of a two part fix for endpoint policy map pressure, for backport purposes the other change was split into a seperate PR: #28184