Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Add Azure CNI Powered by cilium as external installer #28286

Merged
merged 1 commit into from
Jan 19, 2024
Merged

doc: Add Azure CNI Powered by cilium as external installer #28286

merged 1 commit into from
Jan 19, 2024

Conversation

tamilmani1989
Copy link
Contributor

@tamilmani1989 tamilmani1989 commented Sep 26, 2023 •
edited

Added a doc to update installation instructions of cilium via Azure CNI Powered by Cilium AKS cluster. Added a page to describe about delegated ipam.

Related Issue: #27289

@tamilmani1989 tamilmani1989 requested review from a team as code owners September 26, 2023 14:03
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 26, 2023
@tamilmani1989 tamilmani1989 marked this pull request as draft September 26, 2023 14:03
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Sep 26, 2023
@tamilmani1989 tamilmani1989 marked this pull request as ready for review October 17, 2023 15:32
@tamilmani1989
Copy link
Contributor Author

@nbusseneau @joestringer

@nbusseneau nbusseneau self-requested a review October 17, 2023 15:36
@vipul-21 vipul-21 mentioned this pull request Oct 17, 2023
Merged
8 tasks
qmonnet
qmonnet requested changes Oct 18, 2023
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

Please find some minor comments, inline below. Contents look good.

Don't hesitate to add the links to your text ( `see relevant doc <https://some.link>`__) rather than just printing the links themselves (see this long link `<https://some.link>`_), it's more readable.

Also, please squash your commits together.

Documentation/installation/k8s-install-aks.rst Outdated Show resolved Hide resolved
Documentation/installation/k8s-install-aks.rst Outdated Show resolved Hide resolved
Documentation/installation/k8s-install-aks.rst Outdated Show resolved Hide resolved
Documentation/installation/k8s-install-aks.rst Outdated Show resolved Hide resolved
Documentation/installation/k8s-install-aks.rst Outdated Show resolved Hide resolved
Documentation/installation/k8s-install-aks.rst Show resolved Hide resolved
Documentation/installation/k8s-install-aks.rst Show resolved Hide resolved
Documentation/installation/k8s-install-aks.rst Outdated Show resolved Hide resolved
Documentation/installation/k8s-install-aks.rst Outdated Show resolved Hide resolved
Documentation/installation/k8s-install-aks.rst Show resolved Hide resolved
@qmonnet qmonnet added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. area/azure Impacts Azure based IPAM. area/ipam Impacts IP address management functionality. labels Oct 18, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 18, 2023
@qmonnet
Copy link
Member

qmonnet commented Oct 18, 2023

Does this documentation apply to the main branch only, or does it also need backports for Cilium 1.12, 1.13, 1.14?

@tamilmani1989
Copy link
Contributor Author

Does this documentation apply to the main branch only, or does it also need backports for Cilium 1.12, 1.13, 1.14?

it can be backported to 1.12, 1.13 and 1.14

@qmonnet qmonnet added needs-backport/1.12 needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Oct 18, 2023
@learnitall learnitall removed their request for review October 19, 2023 15:56
nbusseneau
nbusseneau reviewed Oct 24, 2023
View reviewed changes
Copy link
Member

@nbusseneau nbusseneau left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tamilmani1989 before I do a review, is this intended to cover everything from #27289 or only your bits?

EDIT: OK I found the other PRs.

@qmonnet qmonnet added this pull request to the merge queue Jan 19, 2024
Merged via the queue into cilium:main with commit 8180cac Jan 19, 2024
59 checks passed
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 19, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in v1.15.0-rc.1 Jan 19, 2024
@giorio94 giorio94 mentioned this pull request Jan 22, 2024
Merged
12 tasks
@giorio94 giorio94 added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Jan 22, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.15 in v1.15.0-rc.1 Jan 22, 2024
@giorio94 giorio94 mentioned this pull request Jan 22, 2024
Merged
11 tasks
@giorio94 giorio94 added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Jan 22, 2024
@giorio94 giorio94 mentioned this pull request Jan 23, 2024
Merged
5 tasks
@giorio94 giorio94 added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Jan 23, 2024
@giorio94 giorio94 mentioned this pull request Jan 24, 2024
Merged
4 tasks
@github-actions github-actions bot added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. backport-pending/1.12 backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Jan 25, 2024
@giorio94 giorio94 added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels Jan 29, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.15 to Backport done to v1.15 in v1.15.0-rc.1 Jan 29, 2024
This was referenced Feb 12, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbusseneau nbusseneau nbusseneau left review comments

@vipul-21 vipul-21 vipul-21 left review comments

@tommyp1ckles tommyp1ckles tommyp1ckles approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/azure Impacts Azure based IPAM. area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/ipam Impacts IP address management functionality. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.13.9
Needs backport from main
1.14.4
Needs backport from main
v1.15.0-rc.1
Backport done to v1.15
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@tamilmani1989 @qmonnet @nbusseneau @dylandreimerink @tommyp1ckles @vipul-21 @joestringer @giorio94