Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bgpv1: set R-bit in graceful restart #28293

Merged
merged 1 commit into from
Oct 20, 2023
Merged

bgpv1: set R-bit in graceful restart #28293

merged 1 commit into from
Oct 20, 2023

Conversation

ArsenyBelorukov
Copy link

Set R-bit in graceful restart negotiation to not withdraw routes by Receiving Speaker Details is in https://www.rfc-editor.org/rfc/rfc4724.html#section-4.1

Fixes: #28168

BGPv1: Set R-bit in graceful restart capability negotiation.

set R-bit in graceful restart
0fe3826 
Set R-bit in graceful restart negotiation to not to withdraw routes by Receiving Speaker
Details is in https://www.rfc-editor.org/rfc/rfc4724.html#section-4.1

Fixes: cilium#28168

Signed-off-by: ArsenyBelorukov <arsenig.n@gmail.com>
@ArsenyBelorukov ArsenyBelorukov requested a review from a team as a code owner September 26, 2023 15:58
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 26, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Sep 26, 2023
@harsimran-pabla harsimran-pabla added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Sep 26, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 26, 2023
@harsimran-pabla harsimran-pabla added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. area/bgp labels Sep 26, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 26, 2023
@lmb
Copy link
Contributor

lmb commented Oct 2, 2023

/test

@danehans
Copy link
Contributor

danehans commented Oct 2, 2023

/ci-clustermesh

@danehans
Copy link
Contributor

danehans commented Oct 2, 2023

/lgtm

As a side note, It's probably a good idea to add a UT for getPeerConfig() in a separate issue/PR so we have coverage here. @harsimran-pabla if you agree, I can create the issue to track.

@harsimran-pabla
Copy link
Contributor

@danehans yes please feel free to do it.

getPeerConfig is getting quite large and it would be good to set a baseline in unit test.

@danehans
Copy link
Contributor

danehans commented Oct 2, 2023

xref: #28363

YutaroHayakawa
YutaroHayakawa approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@YutaroHayakawa YutaroHayakawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 5, 2023
@YutaroHayakawa YutaroHayakawa removed the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 6, 2023
@YutaroHayakawa YutaroHayakawa self-requested a review October 6, 2023 00:59
YutaroHayakawa
YutaroHayakawa requested changes Oct 6, 2023
View reviewed changes
Copy link
Member

@YutaroHayakawa YutaroHayakawa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArsenyBelorukov The change looks good. Please fix the issue of Check Patch workflow (Signed-off-by is missing). You should commit the change with git commit -s option. You can fix your current commit and force push it.

@joestringer
Copy link
Member

It looks like the author and signoff emails for the commit are slightly off, but I think it's fair to assume that these represent aliases for the same person.

@joestringer joestringer merged commit 11b01e3 into cilium:main Oct 20, 2023
60 of 62 checks passed
@YutaroHayakawa YutaroHayakawa added backport/author The backport will be carried out by the author of the PR. needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Feb 15, 2024
@YutaroHayakawa YutaroHayakawa mentioned this pull request Feb 15, 2024
Merged
@julianwiedmann
Copy link
Member

Backport landed via #30793.

@julianwiedmann julianwiedmann added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Feb 20, 2024
@thorn3r thorn3r mentioned this pull request Mar 13, 2024
Merged
@YutaroHayakawa YutaroHayakawa mentioned this pull request Mar 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YutaroHayakawa YutaroHayakawa YutaroHayakawa requested changes

@harsimran-pabla harsimran-pabla harsimran-pabla approved these changes

Assignees
No one assigned
Labels
area/bgp backport/author The backport will be carried out by the author of the PR. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. kind/community-contribution This was a contribution made by a community member. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CFP: BGP: Set R-bit in graceful restart
7 participants
@ArsenyBelorukov @lmb @danehans @harsimran-pabla @joestringer @julianwiedmann @YutaroHayakawa