Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backporting: Revert changes until the new workflow will be in place #28371

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

pippolo84
Copy link
Member

The new GH workflow "Update labels of backported PRs", called from each stable branch, updates each backport-pending PRs to mark them as backport-done when the related backport is merged. So, there should be no need to use the contrib/backporting/set-labels.py to do that anymore.

However, there are still some in-flight backport PRs that rely on the script to do that manually. Thus, this commit reverts the changes in 2966b03 to restore the old script code.

Once all the new GH workflows will be in place for the stable branches and the backport PRs will be created following the new format documented in the backporting docs, the script may be updated.

Fixes: 2966b03 ("backporting: Update docs after introduction of Label Updater")

The new GH workflow "Update labels of backported PRs", called from each
stable branch, updates each `backport-pending` PRs to mark them as
`backport-done` when the related backport is merged. So, there should be
no need to use the contrib/backporting/set-labels.py to do that anymore.

However, there are still some in-flight backport PRs that rely on the
script to do that manually.  Thus, this commit reverts the changes in
2966b03 to restore the old script code.

Once all the new GH workflows will be in place for the stable branches
and the backport PRs will be created following the new format documented
in the backporting docs, the script may be updated.

Fixes: 2966b03 ("backporting: Update docs after introduction of Label Updater")

Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
@pippolo84 pippolo84 added kind/bug/CI This is a bug in the testing code. release-note/bug This PR fixes an issue in a previous release of Cilium. labels Oct 3, 2023
@pippolo84 pippolo84 requested a review from aanm October 3, 2023 13:44
@pippolo84 pippolo84 requested a review from a team as a code owner October 3, 2023 13:44
@aanm aanm merged commit 93f4011 into cilium:main Oct 3, 2023
42 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug/CI This is a bug in the testing code. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants