Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workflows: cilium-config: parametrize egressgw helm values #28389

Merged
merged 1 commit into from
Oct 4, 2023
Merged

workflows: cilium-config: parametrize egressgw helm values #28389

merged 1 commit into from
Oct 4, 2023

Conversation

jibi
Copy link
Member

@jibi jibi commented Oct 4, 2023

No description provided.

@jibi jibi added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels Oct 4, 2023
@jibi
Copy link
Member Author

jibi commented Oct 4, 2023

/test

@jibi
workflows: cilium-config: parametrize egressgw helm values
c43bff7 
Signed-off-by: Gilberto Bertin <jibi@cilium.io>
@jibi jibi force-pushed the pr/jibi/cilium-config-egressgw-helm-values branch from c95a58a to c43bff7 Compare October 4, 2023 07:27
@jibi
Copy link
Member Author

jibi commented Oct 4, 2023

/test

@jibi jibi marked this pull request as ready for review October 4, 2023 08:14
@jibi jibi requested a review from a team as a code owner October 4, 2023 08:14
@jibi jibi requested a review from aditighag October 4, 2023 08:14
pchaigno
pchaigno approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be owned by ci-structure instead of contributing?

@jibi
Copy link
Member Author

jibi commented Oct 4, 2023 •
edited
Loading

Shouldn't this be owned by ci-structure instead of contributing?

sounds like, I'll fill a PR for CODEOWNERS 👍

edit: #28394

@jibi jibi merged commit 43e8447 into main Oct 4, 2023
201 of 203 checks passed
@jibi jibi deleted the pr/jibi/cilium-config-egressgw-helm-values branch October 4, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchaigno pchaigno pchaigno approved these changes

@aditighag aditighag Awaiting requested review from aditighag aditighag was automatically assigned from cilium/contributing

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jibi @pchaigno