GHA: correctly test kvstoremesh in conformance-clustermesh #28434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The kvstoremesh image repository was incorrectly set to `clustermesh-apiserver-ci`. Let's fix it. Fixes: 4498ec9 (".github: re-use common helm values from a single action") Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
|
/ci-clustermesh |
giorio94
added
area/CI
maintainer-s-little-helper
bot
removed
dont-merge/needs-release-note-label
This setting has been incorrectly dropped in a previous commit, let's restore it, so that we keep testing kvstoremesh. Fixes: 4498ec9 (".github: re-use common helm values from a single action") Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
giorio94
force-pushed
the
pr/giorio94/main/gha-clustermesh-kvstoremesh-fix
branch
from
69171b5
to
2e6c83e
Compare
|
/ci-clustermesh |
tklauser
approved these changes
Oct 6, 2023
|
/test |
aanm
approved these changes
Oct 6, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a couple of issues slipped in with #28180.