maps: Consider actual passed time for GC interval calculation #28657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gentoo-root
added
kind/bug
|
/test |
joamaki
reviewed
Oct 24, 2023
gentoo-root
force-pushed
the
fix-gc-interval
branch
2 times, most recently
from
be94e03
to
608fc30
Compare
julianwiedmann
added
sig/datapath
|
This pull request has been automatically marked as stale because it |
github-actions
bot
added
the
stale
gentoo-root
removed
the
stale
|
This pull request has been automatically marked as stale because it |
github-actions
bot
added
the
stale
gentoo-root
removed
the
stale
gentoo-root
force-pushed
the
fix-gc-interval
branch
from
608fc30
to
0e7e818
Compare
|
/test |
gentoo-root
force-pushed
the
fix-gc-interval
branch
from
0e7e818
to
1d80cd4
Compare
|
/test |
gentoo-root
force-pushed
the
fix-gc-interval
branch
from
1d80cd4
to
404c2fc
Compare
|
/test |
When GetInterval calculates the new GC interval, it uses the result of the previous calculation as a pivot point. However, if GC was triggered by a signal, smaller time interval has passed, therefore, expectations on the delete ratio should be lower. Adjust the delete ratio proportionally to avoid increasing the interval uncontrollably when multiple signals arrive over a short period of time. Ref: cilium#27405 Signed-off-by: Maxim Mikityanskiy <maxim@isovalent.com>
gentoo-root
force-pushed
the
fix-gc-interval
branch
from
404c2fc
to
590a1cf
Compare
|
/test |
joamaki
approved these changes
Mar 4, 2024
julianwiedmann
added
affects/v1.12
2 tasks
pippolo84
added
backport-pending/1.15
github-actions
bot
added
backport-done/1.15
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When GetInterval calculates the new GC interval, it uses the result of the previous calculation as a pivot point. However, if GC was triggered by a signal, smaller time interval has passed, therefore, expectations on the delete ratio should be lower. Adjust the delete ratio proportionally to avoid increasing the interval uncontrollably when multiple signals arrive over a short period of time.
Ref: #27405