Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api, cli: Show srv6 status in cilium status #28700

Merged
merged 1 commit into from
Nov 1, 2023
Merged

api, cli: Show srv6 status in cilium status #28700

merged 1 commit into from
Nov 1, 2023

Conversation

husnialhamdani
Copy link
Contributor

@husnialhamdani husnialhamdani commented Oct 19, 2023 •
edited

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

With this pull request, the cilium status will show the status of SRv6 (enabled or not and the encap-mode)

Fixes: #21872

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 19, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Oct 19, 2023
@husnialhamdani husnialhamdani deleted the srv6-status branch October 19, 2023 18:17
@husnialhamdani husnialhamdani restored the srv6-status branch October 19, 2023 18:19
@husnialhamdani husnialhamdani marked this pull request as ready for review October 19, 2023 22:12
@husnialhamdani husnialhamdani requested review from a team as code owners October 19, 2023 22:12
YutaroHayakawa
YutaroHayakawa requested changes Oct 23, 2023
View reviewed changes
Copy link
Member

@YutaroHayakawa YutaroHayakawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Overall, looks nice, but I have some questions + change request.

Also, I want you to cleanup the commit history. Currently there are commits without any message there. Please put them into the single commit (because they are basically touching to the same files) and description of the background of this commit.

api/v1/openapi.yaml Outdated Show resolved Hide resolved
api/v1/openapi.yaml Outdated Show resolved Hide resolved
@maintainer-s-little-helper
Copy link

Commit be9a09d does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Oct 23, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Oct 23, 2023
@husnialhamdani
Copy link
Contributor Author

husnialhamdani commented Oct 23, 2023 •
edited

Thanks for your contribution! Overall, looks nice, but I have some questions + change request.

Also, I want you to cleanup the commit history. Currently there are commits without any message there. Please put them into the single commit (because they are basically touching to the same files) and description of the background of this commit.

Updated to single commit

YutaroHayakawa
YutaroHayakawa requested changes Oct 24, 2023
View reviewed changes
Copy link
Member

@YutaroHayakawa YutaroHayakawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now looks much better! Sorry, one last cosmetic change request.

pkg/client/client.go Outdated Show resolved Hide resolved
YutaroHayakawa
YutaroHayakawa approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@YutaroHayakawa YutaroHayakawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now looks good to me. Thanks!

@YutaroHayakawa
Copy link
Member

/test

@husnialhamdani
api, cli: Show srv6 status in cilium status
00c1fdc 
Signed-off-by: Husni Alhamdani <dhanielluis@gmail.com>
@husnialhamdani
Copy link
Contributor Author

Pushed a commit that include generated zz_generated.deepcopy.go file

@husnialhamdani
Copy link
Contributor Author

/test

@YutaroHayakawa
Copy link
Member

Cilium IPsec upgrade: #28088

@YutaroHayakawa
Copy link
Member

ConformanceEKS: #28693

@YutaroHayakawa
Copy link
Member

Okay, now all tests are passing. @nathanjsweet Could you give this approval? It's a small change, so shouldn't take time.

@dylandreimerink dylandreimerink added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Oct 30, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 30, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 1, 2023
@nathanjsweet nathanjsweet merged commit a2e5509 into cilium:main Nov 1, 2023
62 checks passed
@husnialhamdani husnialhamdani mentioned this pull request Nov 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YutaroHayakawa YutaroHayakawa YutaroHayakawa approved these changes

@nathanjsweet nathanjsweet nathanjsweet approved these changes

Assignees
No one assigned
Labels
kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose SRv6 Status in cilium status --verbose
4 participants
@husnialhamdani @YutaroHayakawa @nathanjsweet @dylandreimerink