-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve CLI user experience for "kubectl get ciliumendpoints" #28744
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In terms of hiding columns, I think this makes sense. I'll leave the review of how this becomes reality to Andre; this is all magic to me, and I don't understand how changing a comment makes the code different :)
Ah CI gives the next steps, see the failed job for |
It seems I missed a step |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Iiqbal2000 please run `make generate-k8s-api && make manifests' and submit your changes
1ebc6d9
to
e0b19af
Compare
Signed-off-by: Iiqbal2000 <iqbalhafizh2000@gmail.com>
e0b19af
to
a1e673f
Compare
I rebased & squashed the commits to tidy it up and to address one of the CI failures. Will trigger full testsuite after the smoke tests go through. |
/test |
Thank you @joestringer |
No action is needed at this time, just looking for the CI tests to complete. I don't expect that this change should impact CI at all, hopefully CI doesn't rely on the textual output of this command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change LGTM. Assuming it passes CI this should be good to merge.
Looks like the external workloads test failed, I can't see any errors aside from not being able to find a specific pod in the connectivity tests, I'll rerun. |
/ci-external-workloads |
Thanks for your contribution @Iiqbal2000 ! |
Fix the empty columns by adding priority fields to columns that may be empty.
Fixes: #27459