gateway-api: Bump the version to v1.0.0-rc1 #28757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
sayboras
added
release-note/minor
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
sayboras
force-pushed
the
tam/gateway-api-1.0.0-rc1
branch
from
4eedc3c
to
ddb3bf8
Compare
|
/test |
sayboras
force-pushed
the
tam/gateway-api-1.0.0-rc1
branch
from
ddb3bf8
to
d258ddd
Compare
|
/test |
sayboras
added
the
needs-backport/1.14
meyskens
approved these changes
Oct 24, 2023
Most of the changes are related to API versions and go dependency, also some of below extra changes: - Add default Listener ResolvedRef condition - Update go.mod to current upstream main commit to include fixes for v1.0.0-rc1 conformance tests Signed-off-by: Tam Mach <tam.mach@cilium.io>
|
/test |
sayboras
force-pushed
the
tam/gateway-api-1.0.0-rc1
branch
from
d258ddd
to
c9c2bb2
Compare
gandro
approved these changes
Oct 24, 2023
Good point, the minimum requirement is to have users install v1 CRDs, then kube api server will be able to publish events for both v1beta1 and v1 resources. I will update the docs separately 👍. |
nebril
approved these changes
Oct 25, 2023
sayboras
removed
the
needs-backport/1.14
aanm
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
As pointed out by other reviewers this will require documentation changes to mention that users need to upgrade the CRD to v1.
I would suggest to add a note in the upgrade guide leaving a node specifically for gateway API users that v1beta1 will NOT work unless the v1 CRD is deployed first.
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the changes are related to API versions and go dependency, also some of below extra changes: