labelsfilter: ignore Job completion index label by default for CID creation #28897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eation This prevents creating a CiliumIdentity object per Pod that is owned by an Indexed Job. This was especially costly in clusters with large quantities of Indexed Job-controlled Pods and basically limited the number of such Pods in a single cluster to a theoretical max number of CID objects (2^16 ~ 65k). Signed-off-by: Antoni Zawodny <zawodny@google.com>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
github-actions
bot
added
the
kind/community-contribution
alan-kut
approved these changes
Oct 31, 2023
|
/test |
qmonnet
added
sig/k8s
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents creating a CiliumIdentity object per Pod that is owned by an Indexed Job. This was especially costly in clusters with large quantities of Indexed Job-controlled Pods and basically limited the number of such Pods in a single cluster to a theoretical max number of CID objects (2^16 ~ 65k).
This is a follow-up to #28003 after the relevant change in the upstream K8s 1.28+.