Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hubble: add option to filter for pods and services in any namespace #28921

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Hubble: add option to filter for pods and services in any namespace #28921

merged 1 commit into from
Nov 30, 2023

Conversation

glrf
Copy link
Contributor

@glrf glrf commented Nov 1, 2023

Please ensure your pull request adheres to the following guidelines:

  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.

We now allow service and pod filters in the form of /foo, which will filter for any service/pod starting with foo in any namespace.

Related to: cilium/hubble#359

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 1, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Nov 1, 2023
@glrf glrf force-pushed the hubble/filter-all-namespaces branch from 3f68127 to fa56001 Compare November 1, 2023 08:56
@glrf glrf marked this pull request as ready for review November 1, 2023 10:52
@glrf glrf requested a review from a team as a code owner November 1, 2023 10:52
@glrf glrf requested a review from chancez November 1, 2023 10:52
@glrf glrf force-pushed the hubble/filter-all-namespaces branch from fa56001 to 71d7fce Compare November 1, 2023 14:45
@glrf glrf requested a review from a team as a code owner November 1, 2023 14:45
@glrf glrf requested a review from rolinh November 1, 2023 14:45
chancez
chancez approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@chancez chancez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting idea, this seems reasonable to me.

@aanm aanm added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Nov 3, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 3, 2023
@aanm
Copy link
Member

aanm commented Nov 3, 2023

/test

rolinh
rolinh reviewed Nov 6, 2023
View reviewed changes
pkg/hubble/filters/k8s.go Outdated Show resolved Hide resolved
@glrf glrf force-pushed the hubble/filter-all-namespaces branch from 71d7fce to c01f7e3 Compare November 6, 2023 14:30
@glrf glrf requested a review from rolinh November 6, 2023 14:57
@lmb
Copy link
Contributor

lmb commented Nov 22, 2023

@rolinh PTAL.

@kaworu kaworu self-requested a review November 27, 2023 09:07
@kaworu kaworu mentioned this pull request Nov 28, 2023
Closed
rolinh
rolinh approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@rolinh rolinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! lgtm

@rolinh rolinh added the sig/hubble Impacts hubble server or relay label Nov 28, 2023
@rolinh rolinh changed the title Add option to filter for pods and services in any namespace Hubble: add option to filter for pods and services in any namespace Nov 28, 2023
kaworu
kaworu approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@kaworu kaworu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kaworu
Copy link
Member

kaworu commented Nov 28, 2023

/test

@glrf
hubble: add option to filter for pods and services in any namespace
a5cb9c6 
We now allow service and pod filters in the form of `/foo`, which will
filter for any service/pod starting with `foo` in any namespace.

Signed-off-by: Fabian Fischer <fabian.fischer@isovalent.com>
@glrf glrf force-pushed the hubble/filter-all-namespaces branch from c01f7e3 to a5cb9c6 Compare November 29, 2023 17:15
@glrf
Copy link
Contributor Author

glrf commented Nov 29, 2023

The CI failures seem unrelated and most likely was because this branch was >400 commits behind main/CI. Rebased on main. Could you please re-trigger tests? :)

@aanm
Copy link
Member

aanm commented Nov 29, 2023

/test

@aanm aanm enabled auto-merge November 29, 2023 20:28
@glrf
Copy link
Contributor Author

glrf commented Nov 30, 2023 •
edited

Test failures seem like unrelated flakes:

@bimmlerd
Copy link
Member

/ci-ipsec-upgrade

@bimmlerd
Copy link
Member

/ci-ginkgo

@bimmlerd
Copy link
Member

/ci-e2e

@bimmlerd
Copy link
Member

/ci-clustermesh

@aanm aanm added this pull request to the merge queue Nov 30, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 30, 2023
Merged via the queue into cilium:main with commit d49d1bb Nov 30, 2023
60 of 61 checks passed
@glrf glrf mentioned this pull request Dec 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaworu kaworu kaworu approved these changes

@rolinh rolinh rolinh approved these changes

@chancez chancez chancez approved these changes

Assignees
No one assigned
Labels
kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium. sig/hubble Impacts hubble server or relay
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@glrf @aanm @lmb @kaworu @bimmlerd @rolinh @chancez