Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gateway-api: add watch for reference grant in TLSRoute reconciler #29007

Merged
merged 2 commits into from
Nov 10, 2023
Merged

gateway-api: add watch for reference grant in TLSRoute reconciler #29007

merged 2 commits into from
Nov 10, 2023

Conversation

mhofstetter
Copy link
Member

This commit adds the missing reference-grant watch to the TLS route controller.

Fixes: #25573 & #25711

@mhofstetter mhofstetter added kind/bug This is a bug in the Cilium logic. release-note/bug This PR fixes an issue in a previous release of Cilium. area/servicemesh GH issues or PRs regarding servicemesh feature/k8s-gateway-api labels Nov 6, 2023
@mhofstetter
Copy link
Member Author

/test

@mhofstetter mhofstetter marked this pull request as ready for review November 6, 2023 16:46
@mhofstetter mhofstetter requested a review from a team as a code owner November 6, 2023 16:46
@mhofstetter mhofstetter changed the title gateway-api: tls route: add watch for reference grant gateway-api: add watch for reference grant in TLSRoute reconciler Nov 6, 2023
meyskens
meyskens approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@meyskens meyskens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit, LGTM overall

operator/pkg/gateway-api/tlsroute.go Outdated Show resolved Hide resolved
@maintainer-s-little-helper maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Nov 8, 2023
@mhofstetter mhofstetter removed the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 8, 2023
@mhofstetter
Copy link
Member Author

/test

@mhofstetter mhofstetter added the needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch label Nov 8, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.14.4 Nov 8, 2023
@mhofstetter
gateway-api: tls route: add watch for reference grant
0b400ad 
This commit adds the missing reference-grant watch to the TLS route controller.

Fixes: cilium#25573 & cilium#25711

Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
@mhofstetter
gateway-api: rename enqueueRequestForReferenceGrant
a727f1d 
This commit fixes the name of the function `enqueueRequestReferenceGrant`
in all the route reconcilers.

Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
@mhofstetter mhofstetter force-pushed the pr/mhofstetter/gw-api-tlsroute-referencegrant-watch branch from 23c6975 to a727f1d Compare November 8, 2023 11:51
@mhofstetter
Copy link
Member Author

rebased to main (without further changes) to get rid of some persistent CI issues (:pray: )

@mhofstetter
Copy link
Member Author

/test

@mhofstetter mhofstetter added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 8, 2023
@mhofstetter
Copy link
Member Author

Re-Added ready-to-merge label - not sure why MLH isn't adding it :/

@thorn3r thorn3r added this to Needs backport from main in 1.14.5 Nov 9, 2023
@thorn3r thorn3r removed this from Needs backport from main in 1.14.4 Nov 9, 2023
@squeed squeed merged commit 554fb6f into cilium:main Nov 10, 2023
61 checks passed
@mhofstetter mhofstetter deleted the pr/mhofstetter/gw-api-tlsroute-referencegrant-watch branch November 10, 2023 09:39
@gandro gandro mentioned this pull request Nov 15, 2023
Merged
6 tasks
@gandro gandro added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Nov 15, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Backport pending to v1.14 in 1.14.4 Nov 15, 2023
@github-actions github-actions bot added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Nov 16, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Backport pending to v1.14 in 1.14.4 Nov 16, 2023
@nebril nebril moved this from Needs backport from main to Backport done to v1.14 in 1.14.5 Dec 11, 2023
@nebril nebril mentioned this pull request Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meyskens meyskens meyskens approved these changes

Assignees
No one assigned
Labels
area/servicemesh GH issues or PRs regarding servicemesh backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. feature/k8s-gateway-api kind/bug This is a bug in the Cilium logic. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
No open projects
1.14.5
Backport done to v1.14
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mhofstetter @meyskens @gandro @squeed