Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/watchdogs: add health reporter to watchdog controller. #29038

Merged
merged 2 commits into from
Nov 13, 2023
Merged

cmd/watchdogs: add health reporter to watchdog controller. #29038

merged 2 commits into from
Nov 13, 2023

Conversation

tommyp1ckles
Copy link
Contributor

@tommyp1ckles tommyp1ckles commented Nov 8, 2023 •
edited
Loading

Watchdog already runs in a module, so we should add a health reporter so it appears in modular health status.

@tommyp1ckles
cmd/watchdogs: add health reporter to watchdog controller.
296960c 
Watchdog already runs in a module, so we should add a health reporter so
it appears in modular health status.

Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 8, 2023
@tommyp1ckles tommyp1ckles marked this pull request as ready for review November 8, 2023 06:25
@tommyp1ckles tommyp1ckles requested a review from a team as a code owner November 8, 2023 06:25
@tommyp1ckles
Copy link
Contributor Author

cc: @derailed

derailed
derailed approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tommyp1ckles LG!

@tommyp1ckles
pkg/health: sort modular health statuses.
924b448 
Due to recent changes to how health status' is sent, the output is no
longer stable.
This sorts the models in the cli application prior to displaying the
health data.

Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
@tommyp1ckles
Copy link
Contributor Author

/test

@tommyp1ckles tommyp1ckles added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Nov 9, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 9, 2023
@tommyp1ckles
Copy link
Contributor Author

pinging @thorn3r 🙂

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 13, 2023
@julianwiedmann julianwiedmann added the area/health Relates to the cilium-health component label Nov 13, 2023
@julianwiedmann julianwiedmann merged commit e0d0938 into cilium:main Nov 13, 2023
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derailed derailed derailed approved these changes

@thorn3r thorn3r thorn3r approved these changes

Assignees
No one assigned
Labels
area/health Relates to the cilium-health component ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tommyp1ckles @derailed @thorn3r @julianwiedmann