Remove deadlock from AuthMap Endpoint GC #29082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
meyskens
added
kind/bug
bimmlerd
reviewed
Nov 9, 2023
christarazi
reviewed
Nov 9, 2023
|
For the release note, typically we'd want to describe the impact of the bug on the user, rather than a description of what the bug is. For example, we'd want to say something like "Fix potential deadlock that results in stale authentication entries in Cilium". |
meyskens
force-pushed
the
meyskens/auth-ep-gc-locks
branch
from
a325c56
to
d60d688
Compare
meyskens
force-pushed
the
meyskens/auth-ep-gc-locks
branch
3 times, most recently
from
b44c74a
to
55a2d96
Compare
meyskens
added
the
release-note/bug
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
meyskens
force-pushed
the
meyskens/auth-ep-gc-locks
branch
2 times, most recently
from
1837248
to
1e26bbf
Compare
|
/test |
|
/test |
christarazi
approved these changes
Nov 22, 2023
mhofstetter
reviewed
Nov 23, 2023
bimmlerd
approved these changes
Nov 23, 2023
meyskens
force-pushed
the
meyskens/auth-ep-gc-locks
branch
from
1e26bbf
to
81b0144
Compare
This change keeps a copy of the endpoints map inside the Autentication GC code. It will be updated on subscribe events, This is then used in the AuthMap GC code instead of doing a call that caused a deadlock. Signed-off-by: Maartje Eyskens <maartje.eyskens@isovalent.com>
meyskens
force-pushed
the
meyskens/auth-ep-gc-locks
branch
from
81b0144
to
19dda85
Compare
mhofstetter
approved these changes
Nov 24, 2023
|
/test |
aditighag
approved these changes
Nov 28, 2023
| @@ -10,11 +10,15 @@ type Subscriber interface { | |||
| // EndpointCreated is called at the end of endpoint creation. | |||
| // Implementations must not attempt write operations on the | |||
| // EndpointManager from this callback. | |||
| // This function is being called inside a RLock, so it must not attempt | |||
There was a problem hiding this comment.
just an fyi: We typically follow the convention - EndpointCreatedLocked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes that a create and delete event from the EndpointManager will also give a "state of the world" update of all current endpoints it has.
This allows the subscribers to check against other endpoints without calling a function that issues a lock when the event was send inside an RLock.
This is then used in the AuthMap GC code instead of doing a call that caused a deadlock.
Fixes: #29078