fix operator dashboard helm template #29106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The config maps fail to render if either dashboard or operator annotations are specified, this is due to the operator annotations not being accessed using $.Values.operator.annotations and fixes the following error. `Error: template: cilium/templates/cilium-operator/dashboards-configmap.yaml:23:20: executing "cilium/templates/cilium-operator/dashboards-configmap.yaml" at <.Values.operator.annotations>: can't evaluate field Values in type []uint8` Signed-off-by: Chris Bannister <c.bannister@gmail.com>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
github-actions
bot
added
the
kind/community-contribution
tommyp1ckles
approved these changes
Nov 11, 2023
There was a problem hiding this comment.
Tested these changes locally, everything looks good.
Thank you for the contribution @Zariel
|
/test |
tommyp1ckles
added
release-note/bug
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
/test |
gandro
approved these changes
Nov 13, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
|
Thank you team :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXXline if the commit addresses a particularGitHub issue.
Fixes: <commit-id>tag, thenplease add the commit author[s] as reviewer[s] to this issue.
The config maps fail to render if either dashboard or operator annotations are specified, this is due to the operator annotations not being accessed using $.Values.operator.annotations and fixes the following error.
Error: template: cilium/templates/cilium-operator/dashboards-configmap.yaml:23:20: executing "cilium/templates/cilium-operator/dashboards-configmap.yaml" at <.Values.operator.annotations>: can't evaluate field Values in type []uint8