pkg/linux/bandwidth: don't start bandwidth manager in dry mode #29183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
dylandreimerink
added
release-note/misc
marseel
approved these changes
Nov 15, 2023
|
/test |
markpash
approved these changes
Nov 27, 2023
dylandreimerink
force-pushed
the
feature/dry-bandwidth-manager
branch
from
468a5be
to
1798cd0
Compare
|
/test |
When dry mode is enabled, we should not register the start hook. The start hook will probe and initialize the bandwidth manager, which should not happen in dry mode. Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com>
As a result of a bad merge in the original PR, the bandwidth manager was not added to the params of the datapath cell. Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com>
dylandreimerink
force-pushed
the
feature/dry-bandwidth-manager
branch
from
1798cd0
to
db2aacb
Compare
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dry mode is enabled, we should not register the start hook. The start hook will probe and initialize the bandwidth manager, which should not happen in dry mode.
This was supposed to go into #28619 but due to a mistake it got merged without this change. So fixing that with this followup PR.